Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

npm min release age#3907

Merged
lolamtisch merged 5 commits into
masterMALSync/MALSync:masterfrom
npm_min_release_ageMALSync/MALSync:npm_min_release_ageCopy head branch name to clipboard
May 20, 2026
Merged

npm min release age#3907
lolamtisch merged 5 commits into
masterMALSync/MALSync:masterfrom
npm_min_release_ageMALSync/MALSync:npm_min_release_ageCopy head branch name to clipboard

Conversation

@lolamtisch

Copy link
Copy Markdown
Member

No description provided.

@lolamtisch
lolamtisch marked this pull request as ready for review May 19, 2026 20:50
Copilot AI review requested due to automatic review settings May 19, 2026 20:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency/tooling configuration to delay very new releases and to move the repository’s Node.js/npm baseline forward for local development and CI.

Changes:

  • Add Renovate minimumReleaseAge to delay updates until releases are at least 2 days old.
  • Raise the required npm version in package.json and enforce engine-strict via .npmrc.
  • Bump GitHub Actions workflows to run on Node.js 24.x.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
renovate.json Adds a global Renovate minimum release age; keeps an npm version constraint.
package.json Updates engines.npm requirement to >=11.0.0.
.npmrc Enforces engine strictness and adds a min-release-age setting.
.github/workflows/tests.yml Updates CI jobs to use Node 24.x.
.github/workflows/release.yml Updates release workflows to use Node 24.x.
.github/workflows/pages.yml Updates Pages workflow to use Node 24.x.
.github/workflows/pages-deploy.yml Updates Pages deploy workflow to use Node 24.x.
.github/workflows/descriptions.yml Updates descriptions workflow to use Node 24.x.
.github/workflows/deployDev.yml Updates dev deploy workflow to use Node 24.x.
.github/workflows/autoUrls.yml Updates autoUrls workflows to use Node 24.x.
Comments suppressed due to low confidence (1)

renovate.json:24

  • Renovate is forced to run with npm 10.x (force.constraints.npm), but this PR raises the repo’s npm engine requirement to >=11 and .npmrc enables engine-strict=true. That combination will likely cause Renovate lockfile updates (and potentially CI on Renovate branches) to fail due to an unsupported npm version. Align these by updating the Renovate npm constraint to 11.x (or removing the constraint) or by relaxing engine-strict for Renovate runs.
  "minimumReleaseAge": "2 days",
  "force": {
    "constraints": {
      "npm": "10.x"
    }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread renovate.json
Comment on lines 17 to 21
"npm": {
"rangeStrategy": "update-lockfile"
},
"minimumReleaseAge": "2 days",
"force": {
Comment thread .npmrc
@@ -1 +1,2 @@
engine-strict=true
min-release-age=2
@lolamtisch
lolamtisch merged commit 5f65b9c into master May 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.