Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add support to StoneScape#3196

Merged
lolamtisch merged 11 commits into
MALSync:masterMALSync/MALSync:masterfrom
gickass:mastergickass/MALSync:masterCopy head branch name to clipboard
Sep 22, 2025
Merged

Add support to StoneScape#3196
lolamtisch merged 11 commits into
MALSync:masterMALSync/MALSync:masterfrom
gickass:mastergickass/MALSync:masterCopy head branch name to clipboard

Conversation

@gickass

@gickass gickass commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

Add support to https://stonescape.xyz

@Source-Dom

Source-Dom commented Sep 20, 2025

Copy link
Copy Markdown
Contributor

Do npm run lint:fix please. Also for future endeavors, you should set your default formatter to prettier eslint, if you don't know how, in VS Code, for example, you can right click your file and press Format document with and then Choose default formatter.

@gickass
gickass marked this pull request as draft September 20, 2025 11:58
@gickass
gickass marked this pull request as ready for review September 20, 2025 13:49
@Source-Dom

Copy link
Copy Markdown
Contributor

Is nextEpUrl supposed to be in manga implementation? Not sure.

@gickass

gickass commented Sep 22, 2025

Copy link
Copy Markdown
Contributor Author

@Source-Dom I'm not sure too, though I add it because some of manga implementation have it too

},
list: {
elementsSelector($c) {
return $c.querySelectorAll('ul li').run();

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too general. It does match more than just the list. You could use something like .listing-chapters_wrap .wp-manga-chapter

Comment on lines +55 to +66
readerConfig: [
{
current: {
selector: '.reading-content img',
mode: 'countAbove',
},
total: {
selector: '.reading-content img',
mode: 'count',
},
},
],

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reader can be set to single page mode. This support both. Can you add it and test it?

readerConfig: [
      {
        condition: '#single-pager',
        current: {
          selector: '#single-pager [selected="selected"]',
          mode: 'text',
          regex: '^(\\d+)/(\\d+)$',
          group: 1,
        },
        total: {
          selector: '#single-pager option',
          mode: 'text',
          regex: '^(\\d+)/(\\d+)$',
          group: 2,
        },
      },
      {
        current: {
          selector: '.reading-content img',
          mode: 'countAbove',
        },
        total: {
          selector: '.reading-content img',
          mode: 'count',
        },
      },
    ],

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For single page, I think it was the website the problem.
It works if the website load properly after clicking for next page from
https://stonescape.xyz/series/plaything/ch-55/p/1/ -> .../p/2/ .../p/3/ and so on

But the website gave blank if clicking next page from
https://stonescape.xyz/series/plaything/ch-55/?style=paged -> https://stonescape.xyz/series/plaything/ch-55/p/2/
needing to reload the second page to load the website.
But because it gave blank on next page, the chapter immediately marked as read

@gickass
gickass requested a review from lolamtisch September 22, 2025 10:52
@lolamtisch
lolamtisch merged commit 0b00988 into MALSync:master Sep 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.