Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixed malsync for miruro site#3181

Merged
lolamtisch merged 3 commits into
MALSync:masterMALSync/MALSync:masterfrom
Debjoy:fix-miruro-not-workingDebjoy/MALSync:fix-miruro-not-workingCopy head branch name to clipboard
Sep 16, 2025
Merged

Fixed malsync for miruro site#3181
lolamtisch merged 3 commits into
MALSync:masterMALSync/MALSync:masterfrom
Debjoy:fix-miruro-not-workingDebjoy/MALSync:fix-miruro-not-workingCopy head branch name to clipboard

Conversation

@Debjoy

@Debjoy Debjoy commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

There has been some URL changes in the site due to which malsync extension wasn't working correctly.
old: /watch?id=20&ep=1
new: /watch/20/naruto/episode-1

Also adjusted such that it can work for below urls as well.
/watch/20/naruto/episode-1
or
/watch/20/naruto#episode-1
or
/watch/20/naruto?episode-1

@lolamtisch lolamtisch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please migrate the implementation to chibi. That way we can directly publish the change without a release.

https://github.com/MALSync/MALSync/wiki/Build

@Debjoy

Debjoy commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

I have just pushed changes to migrate from previous implementation to new chibi implementation.

@Debjoy Debjoy changed the title Fixed malsync for miruro site Draft: Fixed malsync for miruro site Sep 16, 2025
@Debjoy Debjoy changed the title Draft: Fixed malsync for miruro site Fixed malsync for miruro site Sep 16, 2025
@Debjoy
Debjoy marked this pull request as draft September 16, 2025 14:32
@Debjoy

Debjoy commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

I'll update once I fix the tests

@lolamtisch

Copy link
Copy Markdown
Member

Woops I already fixed a few things. Let me know when you are done then

@Debjoy
Debjoy marked this pull request as ready for review September 16, 2025 14:52
@Debjoy

Debjoy commented Sep 16, 2025

Copy link
Copy Markdown
Contributor Author

Oh no worries I saw merge conflict. seems like you have resolved the test case. You can go ahead with merge if needed . Thank you

@lolamtisch
lolamtisch merged commit a395e99 into MALSync:master Sep 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.