Fixed malsync for miruro site#3181
Merged
lolamtisch merged 3 commits intoSep 16, 2025
MALSync:masterMALSync/MALSync:masterfrom
Debjoy:fix-miruro-not-workingDebjoy/MALSync:fix-miruro-not-workingCopy head branch name to clipboard
Merged
Fixed malsync for miruro site#3181lolamtisch merged 3 commits intoMALSync:masterMALSync/MALSync:masterfrom Debjoy:fix-miruro-not-workingDebjoy/MALSync:fix-miruro-not-workingCopy head branch name to clipboard
lolamtisch merged 3 commits into
MALSync:masterMALSync/MALSync:masterfrom
Debjoy:fix-miruro-not-workingDebjoy/MALSync:fix-miruro-not-workingCopy head branch name to clipboard
Conversation
lolamtisch
requested changes
Sep 15, 2025
lolamtisch
left a comment
Member
There was a problem hiding this comment.
Please migrate the implementation to chibi. That way we can directly publish the change without a release.
Contributor
Author
|
I have just pushed changes to migrate from previous implementation to new chibi implementation. |
Debjoy
marked this pull request as draft
September 16, 2025 14:32
Contributor
Author
|
I'll update once I fix the tests |
Member
|
Woops I already fixed a few things. Let me know when you are done then |
Debjoy
marked this pull request as ready for review
September 16, 2025 14:52
Contributor
Author
|
Oh no worries I saw merge conflict. seems like you have resolved the test case. You can go ahead with merge if needed . Thank you |
lolamtisch
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There has been some URL changes in the site due to which malsync extension wasn't working correctly.
old: /watch?id=20&ep=1
new: /watch/20/naruto/episode-1
Also adjusted such that it can work for below urls as well.
/watch/20/naruto/episode-1
or
/watch/20/naruto#episode-1
or
/watch/20/naruto?episode-1