Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Overview/Search bar fixes#2855

Merged
lolamtisch merged 2 commits into
MALSync:masterMALSync/MALSync:masterfrom
DFreezerR:general-fixesDFreezerR/MALSync:general-fixesCopy head branch name to clipboard
Apr 25, 2025
Merged

Overview/Search bar fixes#2855
lolamtisch merged 2 commits into
MALSync:masterMALSync/MALSync:masterfrom
DFreezerR:general-fixesDFreezerR/MALSync:general-fixesCopy head branch name to clipboard

Conversation

@DFreezerR

@DFreezerR DFreezerR commented Feb 24, 2025

Copy link
Copy Markdown
Contributor

There were several issues. Sending in 1 PR since they are quite small.
Issues:

  1. Despite overview description section's div having description-html class, links tags looks the same as normal text. I think it will be better to somehow highlight them.
  2. Said links MAY also open in pop up window itself, not in new browser tab (if they don't have target attr).
  3. Using search bar from bookmarks view AND erasing input or going back to bookmarks makes both anime/manga radio switches unchecked

Obviously links only works if they are provided in description string as part of meta data.

Search bar before:

search1

Search bar after:

search2

Overview description before:

links1

Overview description after:

Do not mind changed banner. That's another PR
links2

*pardon my overview in different lang

@lolamtisch
lolamtisch merged commit f932435 into MALSync:master Apr 25, 2025
@DFreezerR
DFreezerR deleted the general-fixes branch May 3, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.