Add save_rows to Query API#83
Merged
Merged
Add save_rows to Query API#83
Conversation
labkey-alan
approved these changes
Jul 8, 2025
labkey-alan
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for updating the supported versions.
This was referenced Sep 16, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
This PR adds
save_rowsto the Query API. Accessible via api wrapper asapi.query.save_rows.Implementation note: This makes use of
TypedDictto improve static type analysis for this API.TypedDictwas made available starting in Python 3.8. We currently support Python 3.7+, however 3.7 was EOL back in October of 2024. To this end, I've updated our minimum required version to 3.10 which will EOL in October of 2026. Certainly willing to shift this depending on how disruptive this may or may not be to users. I've also updated thesetup.pyto specifypython_requires=">=3.10"which will make our required version more clear to users and Python repositories. To make sure this doesn't catch anyone off-guard I've bumped the package version to4.0.0.Changes
query-saveRows.apinamedsave_rows()python_requiresinsetup.py