Don't configure toolsDirectory in the global pipelineConfig.xml#331
Merged
labkey-tchad merged 2 commits intoJan 10, 2025
developLabKey/DiscvrLabKeyModules:developfrom
fb_jBrowseTestSetPipelineToolsDirLabKey/DiscvrLabKeyModules:fb_jBrowseTestSetPipelineToolsDirCopy head branch name to clipboard
Merged
Don't configure toolsDirectory in the global pipelineConfig.xml#331labkey-tchad merged 2 commits intodevelopLabKey/DiscvrLabKeyModules:developfrom fb_jBrowseTestSetPipelineToolsDirLabKey/DiscvrLabKeyModules:fb_jBrowseTestSetPipelineToolsDirCopy head branch name to clipboard
toolsDirectory in the global pipelineConfig.xml#331labkey-tchad merged 2 commits into
developLabKey/DiscvrLabKeyModules:developfrom
fb_jBrowseTestSetPipelineToolsDirLabKey/DiscvrLabKeyModules:fb_jBrowseTestSetPipelineToolsDirCopy head branch name to clipboard
Conversation
This reverts commit 0728b90.
labkey-jeckels
approved these changes
Jan 9, 2025
bbimber
pushed a commit
that referenced
this pull request
Jun 16, 2025
Co-authored-by: Sebastian Benjamin <sebastiancbenjamin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The JBrowseTest failure was due to a test ordering issue. The test had an implicit dependency on another test that was customizing the pipeline tools directory via UI. The correct fix is to make
BaseWebDriverTestresponsible for customizing the pipeline tools if theadditional.pipeline.toolsproperty is configured.Related Pull Requests
additional.pipeline.toolstestAutomation#2224Changes
toolsDirectoryin the globalpipelineConfig.xml