Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 1c8a3ff

Browse filesBrowse files
committed
[Walmart] Comment out localad rules.
Rules were breaking tests, and the redirect target, weeklyad.walmart.com, had an invalid certificate.
1 parent d8a2c11 commit 1c8a3ff
Copy full SHA for 1c8a3ff

1 file changed

+8-4Lines changed: 8 additions & 4 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/chrome/content/rules/Walmart.com.xml‎

Copy file name to clipboardExpand all lines: src/chrome/content/rules/Walmart.com.xml
+8-4Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@
144144
<!-- Complications:
145145
-->
146146
<target host="walmart.com" />
147-
<target host="localad.walmart.com" />
147+
<!-- <target host="localad.walmart.com" /> -->
148148
<target host="p13n-assets.walmart.com" />
149149

150150
<!-- Redirect to http:
@@ -190,19 +190,23 @@
190190
<test url="http://help.walmart.com/euf/assets/images/BTN_search_75x30.png" />
191191
<test url="http://help.walmart.com/favicon.ico" />
192192

193+
<!--
193194
<exclusion pattern="^http://localad\.walmart\.com/+(?!$|\?)" />
195+
-->
194196

195197
<!-- +ve:
196198
-->
199+
<!--
197200
<test url="http://localad.walmart.com/f" />
198201
<test url="http://localad.walmart.com/o" />
199202
<test url="http://localad.walmart.com//o" />
200203
<test url="http://localad.walmart.com/b" />
201204
<test url="http://localad.walmart.com/a" />
205+
-->
202206

203207
<!-- -ve:
204208
-->
205-
<test url="http://localad.walmart.com//" />
209+
<!-- <test url="http://localad.walmart.com//" /> -->
206210

207211
<test url="http://beacon.walmart.com/tap.gif?tap=" />
208212

@@ -227,8 +231,8 @@
227231

228232
<!-- Redirect keeps args:
229233
-->
230-
<rule from="^http://localad\.walmart\.com/+"
231-
to="https://weeklyad.walmart.com/walmart/" />
234+
<!-- <rule from="^http://localad\.walmart\.com/+"
235+
to="https://weeklyad.walmart.com/walmart/" /> -->
232236

233237
<rule from="^http://p13n-assets\.walmart\.com/"
234238
to="https://a248.e.akamai.net/f/1697/4479/7/p13n-assets.walmart.com/" />

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.