Open
Conversation
Member
Author
|
Bump 🙂 |
|
Coincidentally double bump :) |
Moelf
reviewed
Apr 8, 2025
Moelf
reviewed
Apr 8, 2025
Co-authored-by: Jerry Ling <proton@jling.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 63.55% 64.54% +0.99%
==========================================
Files 1 1
Lines 107 110 +3
==========================================
+ Hits 68 71 +3
Misses 39 39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
@stevengj I was just reminded of this PR and noticed that it's still open 🙂 |
Member
|
Yes, since we are planning a breaking change anyway with #42 it would make sense to merge this in the same release… |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes the first point in #31 and starts the sequence at zero (see #31 and Owen's paper referenced therein for the motivation). With this change the sequences generated by Sobol.jl now actually match the reference sequences in https://github.com/JuliaMath/Sobol.jl/tree/master/test/results which already include zero as initial point.