Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

typos#224

Merged
meggart merged 1 commit intomasterJuliaDataCubes/EarthDataLab.jl:masterfrom
gdkrmr-patch-1JuliaDataCubes/EarthDataLab.jl:gdkrmr-patch-1Copy head branch name to clipboard
Nov 13, 2020
Merged

typos#224
meggart merged 1 commit intomasterJuliaDataCubes/EarthDataLab.jl:masterfrom
gdkrmr-patch-1JuliaDataCubes/EarthDataLab.jl:gdkrmr-patch-1Copy head branch name to clipboard

Conversation

@gdkrmr
Copy link
Copy Markdown
Collaborator

@gdkrmr gdkrmr commented Nov 12, 2020

No description provided.

@meggart meggart merged commit ab49182 into master Nov 13, 2020
@gdkrmr gdkrmr deleted the gdkrmr-patch-1 branch November 13, 2020 14:42
meggart added a commit that referenced this pull request Dec 7, 2020
* Start reworking everything

* Loading cubes works again

* mapslices running

* Simple mapslices works

* Access tests pass

* Tests pass with new data type

* Code improvements and TODOs based on @felixcremer s comments

* add CubeAxis import to Shapes.jl

* some fixes

* small fix for readblock

* Show CodeCov badge in README

* fix bug when subsetting concatcubes

* Implement changes suggested by @felixcremer

* Add sync after exporting cube

* Require NetCDF 0.10

* make it load again

* Fix ambiguity

* Fix cartind bug

* Add DiskArrays as direct dependency

This doesn't solve the test failure because some readblock! method is
still missing.

* Fix bug in readblock!

* Import readblock! from Zarr

I also changed the import Zarr to using Zarr: ... and sorted the imports
into types and functions which are sorted alphabetically.

* Make wrap keyword available in cubefromshape (#199)

Wrap is a keyword which is projection specific and which gives the
projection value at which the projection wraps into itself.
The default values fail for non Lat Lon projections.
Therefore, this makes the keyword available in the cubefromshape
interface.
This is an intermediate solution, because it would be better to have the
projection as a metadata information of a cube, so that we could use
this to set the wrapping values.

* Revert "Make wrap keyword available in cubefromshape (#199)"

This reverts commit 6e778a2.
Unfortunately, this pull request was not yet ready.
I should have indicated that more clearly.
I am reverting this for now and then I am going to push a tidied up
version of the PR.

* Change clone to add in readme install instructions

Clone is the keyword from the old package manger.

* Update README.md

* typos (#224)

* Split packages (#198)

* Removed a lot of files

* move some files

* break more things

* Clean up Proc module

* Many fixes to get dataset creation running again

* savecube to netcdf works

* more improvements

* Commit many more changes

* Separate out API

* some test fixes

* switch to YAXArrayBase

* read variables in a typed way

* add ESDLArray export

* Fixes to remap

* remove NetCDF and Zarr dependency

* delete some unused stuff

* Do not permute cubes by default

* Add concatenations

* Fixes to findaxis

* Tests pass again

* Try to fix chunking

* dont depend on reexport

* remove reexport dep

* dont forgegt using it

* update test

* Allow NamedTuples

* minor changes

* Finalsplit (#220)

* Delete almost everything

* More updates

* Old tests for ESDL pass

* More changes

* Fix bugs in ESDL

* Some fixes

* Fix some warnings

* tests should pass

* Start reworking everything

* Loading cubes works again

* mapslices running

* Simple mapslices works

* Access tests pass

* Tests pass with new data type

* Code improvements and TODOs based on @felixcremer s comments

* add CubeAxis import to Shapes.jl

* some fixes

* fix bug when subsetting concatcubes

* Implement changes suggested by @felixcremer

* Add sync after exporting cube

* Require NetCDF 0.10

* make it load again

* Fix ambiguity

* Split packages (#198)

* Removed a lot of files

* move some files

* break more things

* Clean up Proc module

* Many fixes to get dataset creation running again

* savecube to netcdf works

* more improvements

* Commit many more changes

* Separate out API

* some test fixes

* switch to YAXArrayBase

* read variables in a typed way

* add ESDLArray export

* Fixes to remap

* remove NetCDF and Zarr dependency

* delete some unused stuff

* Do not permute cubes by default

* Add concatenations

* Fixes to findaxis

* Tests pass again

* Try to fix chunking

* dont depend on reexport

* remove reexport dep

* dont forgegt using it

* update test

* Allow NamedTuples

* minor changes

* Finalsplit (#220)

* Delete almost everything

* More updates

* Old tests for ESDL pass

* More changes

* Fix bugs in ESDL

* Some fixes

* Fix some warnings

* tests should pass

Co-authored-by: Felix Cremer <felix.cremer@uni-jena.de>
Co-authored-by: Guido Kraemer <gdkrmr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.