Make wrap keyword available in cubefromshape#199
Merged
Make wrap keyword available in cubefromshape#199
Conversation
Wrap is a keyword which is projection specific and which gives the projection value at which the projection wraps into itself. The default values fail for non Lat Lon projections. Therefore, this makes the keyword available in the cubefromshape interface. This is an intermediate solution, because it would be better to have the projection as a metadata information of a cube, so that we could use this to set the wrapping values.
felixcremer
pushed a commit
that referenced
this pull request
Apr 15, 2020
This reverts commit 6e778a2. Unfortunately, this pull request was not yet ready. I should have indicated that more clearly. I am reverting this for now and then I am going to push a tidied up version of the PR.
meggart
added a commit
that referenced
this pull request
Dec 7, 2020
* Start reworking everything * Loading cubes works again * mapslices running * Simple mapslices works * Access tests pass * Tests pass with new data type * Code improvements and TODOs based on @felixcremer s comments * add CubeAxis import to Shapes.jl * some fixes * small fix for readblock * Show CodeCov badge in README * fix bug when subsetting concatcubes * Implement changes suggested by @felixcremer * Add sync after exporting cube * Require NetCDF 0.10 * make it load again * Fix ambiguity * Fix cartind bug * Add DiskArrays as direct dependency This doesn't solve the test failure because some readblock! method is still missing. * Fix bug in readblock! * Import readblock! from Zarr I also changed the import Zarr to using Zarr: ... and sorted the imports into types and functions which are sorted alphabetically. * Make wrap keyword available in cubefromshape (#199) Wrap is a keyword which is projection specific and which gives the projection value at which the projection wraps into itself. The default values fail for non Lat Lon projections. Therefore, this makes the keyword available in the cubefromshape interface. This is an intermediate solution, because it would be better to have the projection as a metadata information of a cube, so that we could use this to set the wrapping values. * Revert "Make wrap keyword available in cubefromshape (#199)" This reverts commit 6e778a2. Unfortunately, this pull request was not yet ready. I should have indicated that more clearly. I am reverting this for now and then I am going to push a tidied up version of the PR. * Change clone to add in readme install instructions Clone is the keyword from the old package manger. * Update README.md * typos (#224) * Split packages (#198) * Removed a lot of files * move some files * break more things * Clean up Proc module * Many fixes to get dataset creation running again * savecube to netcdf works * more improvements * Commit many more changes * Separate out API * some test fixes * switch to YAXArrayBase * read variables in a typed way * add ESDLArray export * Fixes to remap * remove NetCDF and Zarr dependency * delete some unused stuff * Do not permute cubes by default * Add concatenations * Fixes to findaxis * Tests pass again * Try to fix chunking * dont depend on reexport * remove reexport dep * dont forgegt using it * update test * Allow NamedTuples * minor changes * Finalsplit (#220) * Delete almost everything * More updates * Old tests for ESDL pass * More changes * Fix bugs in ESDL * Some fixes * Fix some warnings * tests should pass * Start reworking everything * Loading cubes works again * mapslices running * Simple mapslices works * Access tests pass * Tests pass with new data type * Code improvements and TODOs based on @felixcremer s comments * add CubeAxis import to Shapes.jl * some fixes * fix bug when subsetting concatcubes * Implement changes suggested by @felixcremer * Add sync after exporting cube * Require NetCDF 0.10 * make it load again * Fix ambiguity * Split packages (#198) * Removed a lot of files * move some files * break more things * Clean up Proc module * Many fixes to get dataset creation running again * savecube to netcdf works * more improvements * Commit many more changes * Separate out API * some test fixes * switch to YAXArrayBase * read variables in a typed way * add ESDLArray export * Fixes to remap * remove NetCDF and Zarr dependency * delete some unused stuff * Do not permute cubes by default * Add concatenations * Fixes to findaxis * Tests pass again * Try to fix chunking * dont depend on reexport * remove reexport dep * dont forgegt using it * update test * Allow NamedTuples * minor changes * Finalsplit (#220) * Delete almost everything * More updates * Old tests for ESDL pass * More changes * Fix bugs in ESDL * Some fixes * Fix some warnings * tests should pass Co-authored-by: Felix Cremer <felix.cremer@uni-jena.de> Co-authored-by: Guido Kraemer <gdkrmr@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap is a keyword which is projection specific and which gives the
projection value at which the projection wraps into itself.
The default values fail for non Lat Lon projections.
Therefore, this makes the keyword available in the cubefromshape
interface.
This is an intermediate solution, because it would be better to have the
projection as a metadata information of a cube, so that we could use
this to set the wrapping values.