Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fe6bd30

Browse filesBrowse files
starrifyCommit Bot
authored andcommitted
[build] Add new build argument v8_symbol_level
May override the global symbol_level config. Useful for debugging V8 within a release Chromium, like v8_enable_debugging_features. Change-Id: Ie081b5110dc93914cbe53fdde3cdec77822b9819 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051959 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66262}
1 parent f440271 commit fe6bd30
Copy full SHA for fe6bd30

2 files changed

+17Lines changed: 17 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎AUTHORS‎

Copy file name to clipboardExpand all lines: AUTHORS
+1Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,7 @@ Oliver Dunk <oliver@oliverdunk.com>
151151
Paolo Giarrusso <p.giarrusso@gmail.com>
152152
Patrick Gansterer <paroga@paroga.com>
153153
Peng Fei <pfgenyun@gmail.com>
154+
Peng-Yu Chen <pengyu@libstarrify.so>
154155
Peter Rybin <peter.rybin@gmail.com>
155156
Peter Varga <pvarga@inf.u-szeged.hu>
156157
Peter Wong <peter.wm.wong@gmail.com>
Collapse file

‎gni/v8.gni‎

Copy file name to clipboardExpand all lines: gni/v8.gni
+16Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,9 @@ declare_args() {
5757
# Use Perfetto (https://perfetto.dev) as the default TracingController. Not
5858
# currently implemented.
5959
v8_use_perfetto = false
60+
61+
# Override global symbol level setting for v8
62+
v8_symbol_level = symbol_level
6063
}
6164

6265
if (v8_use_external_startup_data == "") {
@@ -116,6 +119,19 @@ if (v8_code_coverage && !is_clang) {
116119
]
117120
}
118121

122+
if (v8_symbol_level != symbol_level) {
123+
v8_remove_configs += [ "//build/config/compiler:default_symbols" ]
124+
if (v8_symbol_level == 0) {
125+
v8_add_configs += [ "//build/config/compiler:no_symbols" ]
126+
} else if (v8_symbol_level == 1) {
127+
v8_add_configs += [ "//build/config/compiler:minimal_symbols" ]
128+
} else if (v8_symbol_level == 2) {
129+
v8_add_configs += [ "//build/config/compiler:symbols" ]
130+
} else {
131+
assert(false)
132+
}
133+
}
134+
119135
if ((is_posix || is_fuchsia) &&
120136
(v8_enable_backtrace || v8_monolithic || v8_expose_symbols)) {
121137
v8_remove_configs += [ "//build/config/gcc:symbol_visibility_hidden" ]

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.