Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit f21973e

Browse filesBrowse files
jernoblejernoble
committed
[MediaSession] Small refactoring of MediaSession implementation classes
https://bugs.webkit.org/show_bug.cgi?id=224141 Reviewed by Eric Carlson. A smorgasboard of small refactoring changes: Source/WebCore: - Don't call action handlers by default in response to coordinator requests. - Since we don't call the action handlers, we don't need the internal methods. - Simplify the call site by defining the action details inline. * Modules/mediasession/MediaSessionCoordinator.cpp: (WebCore::MediaSessionCoordinator::seekSessionToTime): (WebCore::MediaSessionCoordinator::playSession): (WebCore::MediaSessionCoordinator::pauseSession): (WebCore::MediaSessionCoordinator::setSessionTrack): (WebCore::MediaSessionCoordinator::internalSeekTo): Deleted. (WebCore::MediaSessionCoordinator::internalPlay): Deleted. (WebCore::MediaSessionCoordinator::internalPause): Deleted. (WebCore::MediaSessionCoordinator::internalSetTrack): Deleted. * Modules/mediasession/MediaSessionCoordinator.h: * Modules/mediasession/MediaSessionCoordinatorPrivate.h: Source/WebKit: - MediaSessionCoordinatorProxyPrivate should use an Optional<ExceptionData> rather than an actual ExceptionData, to handle the case where no exception was encoutered. - RemoteMediaSessionCoordinatorProxy::create() should just return a Ref, not a RefPtr. - Logging inside a completion handler requires access to this. - Add RemoteMediaSessionCoordinatorProxy.cpp to the build. * UIProcess/Media/MediaSessionCoordinatorProxyPrivate.h: * UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp: (WebKit::RemoteMediaSessionCoordinatorProxy::create): (WebKit::RemoteMediaSessionCoordinatorProxy::RemoteMediaSessionCoordinatorProxy): (WebKit::RemoteMediaSessionCoordinatorProxy::join): (WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSeekTo): (WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePlay): (WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePause): (WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSetTrack): (WebKit::RemoteMediaSessionCoordinatorProxy::pauseSession): (WebKit::RemoteMediaSessionCoordinatorProxy::setSessionTrack): (WebKit::RemoteMediaSessionCoordinatorProxy::logChannel const): (WebKit::RemoteMediaSessionCoordinatorProxy::::coordinateSetTrack): Deleted. * UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h: (WebKit::RemoteMediaSessionCoordinatorProxy::logger const): (WebKit::RemoteMediaSessionCoordinatorProxy::logIdentifier const): (WebKit::RemoteMediaSessionCoordinatorProxy::logClassName const): Canonical link: https://commits.webkit.org/236118@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@275458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
1 parent d98d247 commit f21973e
Copy full SHA for f21973e

9 files changed

+131-96Lines changed: 131 additions & 96 deletions
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎Source/WebCore/ChangeLog‎

Copy file name to clipboardExpand all lines: Source/WebCore/ChangeLog
+25Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,28 @@
1+
2021-04-05 Jer Noble <jer.noble@apple.com>
2+
3+
[MediaSession] Small refactoring of MediaSession implementation classes
4+
https://bugs.webkit.org/show_bug.cgi?id=224141
5+
6+
Reviewed by Eric Carlson.
7+
8+
A smorgasboard of small refactoring changes:
9+
10+
- Don't call action handlers by default in response to coordinator requests.
11+
- Since we don't call the action handlers, we don't need the internal methods.
12+
- Simplify the call site by defining the action details inline.
13+
14+
* Modules/mediasession/MediaSessionCoordinator.cpp:
15+
(WebCore::MediaSessionCoordinator::seekSessionToTime):
16+
(WebCore::MediaSessionCoordinator::playSession):
17+
(WebCore::MediaSessionCoordinator::pauseSession):
18+
(WebCore::MediaSessionCoordinator::setSessionTrack):
19+
(WebCore::MediaSessionCoordinator::internalSeekTo): Deleted.
20+
(WebCore::MediaSessionCoordinator::internalPlay): Deleted.
21+
(WebCore::MediaSessionCoordinator::internalPause): Deleted.
22+
(WebCore::MediaSessionCoordinator::internalSetTrack): Deleted.
23+
* Modules/mediasession/MediaSessionCoordinator.h:
24+
* Modules/mediasession/MediaSessionCoordinatorPrivate.h:
25+
126
2021-04-05 Yusuke Suzuki <ysuzuki@apple.com>
227

328
Define AtomString(ASCIILiteral) and use ASCIILiteral more to avoid memory allocation
Collapse file

‎Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp‎

Copy file name to clipboardExpand all lines: Source/WebCore/Modules/mediasession/MediaSessionCoordinator.cpp
+10-60Lines changed: 10 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -292,7 +292,8 @@ void MediaSessionCoordinator::seekSessionToTime(double time, CompletionHandler<v
292292
return;
293293
}
294294

295-
completionHandler(internalSeekTo(time));
295+
m_session->callActionHandler({ .action = MediaSessionAction::Seekto, .seekTime = time });
296+
completionHandler(true);
296297
}
297298

298299
void MediaSessionCoordinator::playSession(CompletionHandler<void(bool)>&& completionHandler)
@@ -304,10 +305,11 @@ void MediaSessionCoordinator::playSession(CompletionHandler<void(bool)>&& comple
304305
return;
305306
}
306307

307-
completionHandler(internalPlay());
308+
m_session->callActionHandler({ .action = MediaSessionAction::Play });
309+
completionHandler(true);
308310
}
309311

310-
void MediaSessionCoordinator::pauseSession(CompletionHandler<void(bool)> completionHandler)
312+
void MediaSessionCoordinator::pauseSession(CompletionHandler<void(bool)>&& completionHandler)
311313
{
312314
ALWAYS_LOG(LOGIDENTIFIER, m_state);
313315

@@ -316,10 +318,11 @@ void MediaSessionCoordinator::pauseSession(CompletionHandler<void(bool)> complet
316318
return;
317319
}
318320

319-
completionHandler(internalPause());
321+
m_session->callActionHandler({ .action = MediaSessionAction::Play });
322+
completionHandler(true);
320323
}
321324

322-
void MediaSessionCoordinator::setSessionTrack(const String& track, CompletionHandler<void(bool)> completionHandler)
325+
void MediaSessionCoordinator::setSessionTrack(const String& track, CompletionHandler<void(bool)>&& completionHandler)
323326
{
324327
ALWAYS_LOG(LOGIDENTIFIER, m_state, ", ", track);
325328

@@ -328,61 +331,8 @@ void MediaSessionCoordinator::setSessionTrack(const String& track, CompletionHan
328331
return;
329332
}
330333

331-
completionHandler(internalSetTrack(track));
332-
}
333-
334-
bool MediaSessionCoordinator::internalSeekTo(double time)
335-
{
336-
if (!m_session)
337-
return false;
338-
339-
MediaSessionActionDetails details {
340-
.action = MediaSessionAction::Seekto,
341-
.seekTime = time,
342-
};
343-
m_session->callActionHandler(details);
344-
345-
return true;
346-
}
347-
348-
bool MediaSessionCoordinator::internalPlay()
349-
{
350-
if (!m_session)
351-
return false;
352-
353-
MediaSessionActionDetails details {
354-
.action = MediaSessionAction::Play,
355-
};
356-
m_session->callActionHandler(details);
357-
358-
return true;
359-
}
360-
361-
bool MediaSessionCoordinator::internalPause()
362-
{
363-
if (!m_session)
364-
return false;
365-
366-
MediaSessionActionDetails details {
367-
.action = MediaSessionAction::Pause,
368-
};
369-
m_session->callActionHandler(details);
370-
371-
return true;
372-
}
373-
374-
bool MediaSessionCoordinator::internalSetTrack(const String& track)
375-
{
376-
if (!m_session)
377-
return false;
378-
379-
MediaSessionActionDetails details {
380-
.action = MediaSessionAction::Settrack,
381-
.trackIdentifier = track,
382-
};
383-
m_session->callActionHandler(details);
384-
385-
return true;
334+
m_session->callActionHandler({ .action = MediaSessionAction::Settrack, .trackIdentifier = track });
335+
completionHandler(true);
386336
}
387337

388338
WTFLogChannel& MediaSessionCoordinator::logChannel()
Collapse file

‎Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h‎

Copy file name to clipboardExpand all lines: Source/WebCore/Modules/mediasession/MediaSessionCoordinator.h
+2-7Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -73,13 +73,8 @@ class MediaSessionCoordinator
7373
// MediaSessionCoordinatorClient
7474
void seekSessionToTime(double, CompletionHandler<void(bool)>&&) final;
7575
void playSession(CompletionHandler<void(bool)>&&) final;
76-
void pauseSession(CompletionHandler<void(bool)>) final;
77-
void setSessionTrack(const String&, CompletionHandler<void(bool)>) final;
78-
79-
bool internalSeekTo(double);
80-
bool internalPlay();
81-
bool internalPause();
82-
bool internalSetTrack(const String&);
76+
void pauseSession(CompletionHandler<void(bool)>&&) final;
77+
void setSessionTrack(const String&, CompletionHandler<void(bool)>&&) final;
8378

8479
const Logger& logger() const { return m_logger; }
8580
const void* logIdentifier() const { return m_logIdentifier; }
Collapse file

‎Source/WebCore/Modules/mediasession/MediaSessionCoordinatorPrivate.h‎

Copy file name to clipboardExpand all lines: Source/WebCore/Modules/mediasession/MediaSessionCoordinatorPrivate.h
+3-2Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
#include "MediaSessionPlaybackState.h"
3434
#include "MediaSessionReadyState.h"
3535
#include <wtf/Optional.h>
36+
#include <wtf/WeakPtr.h>
3637

3738
namespace WTF {
3839
class Logger;
@@ -46,8 +47,8 @@ class MediaSessionCoordinatorClient : public CanMakeWeakPtr<MediaSessionCoordina
4647

4748
virtual void seekSessionToTime(double, CompletionHandler<void(bool)>&&) = 0;
4849
virtual void playSession(CompletionHandler<void(bool)>&&) = 0;
49-
virtual void pauseSession(CompletionHandler<void(bool)>) = 0;
50-
virtual void setSessionTrack(const String&, CompletionHandler<void(bool)>) = 0;
50+
virtual void pauseSession(CompletionHandler<void(bool)>&&) = 0;
51+
virtual void setSessionTrack(const String&, CompletionHandler<void(bool)>&&) = 0;
5152
};
5253

5354
class MediaSessionCoordinatorPrivate : public RefCounted<MediaSessionCoordinatorPrivate> {
Collapse file

‎Source/WebKit/ChangeLog‎

Copy file name to clipboardExpand all lines: Source/WebKit/ChangeLog
+33Lines changed: 33 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,36 @@
1+
2021-04-05 Jer Noble <jer.noble@apple.com>
2+
3+
[MediaSession] Small refactoring of MediaSession implementation classes
4+
https://bugs.webkit.org/show_bug.cgi?id=224141
5+
6+
Reviewed by Eric Carlson.
7+
8+
A smorgasboard of small refactoring changes:
9+
10+
- MediaSessionCoordinatorProxyPrivate should use an Optional<ExceptionData> rather than
11+
an actual ExceptionData, to handle the case where no exception was encoutered.
12+
- RemoteMediaSessionCoordinatorProxy::create() should just return a Ref, not a RefPtr.
13+
- Logging inside a completion handler requires access to this.
14+
- Add RemoteMediaSessionCoordinatorProxy.cpp to the build.
15+
16+
* UIProcess/Media/MediaSessionCoordinatorProxyPrivate.h:
17+
* UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp:
18+
(WebKit::RemoteMediaSessionCoordinatorProxy::create):
19+
(WebKit::RemoteMediaSessionCoordinatorProxy::RemoteMediaSessionCoordinatorProxy):
20+
(WebKit::RemoteMediaSessionCoordinatorProxy::join):
21+
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSeekTo):
22+
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePlay):
23+
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinatePause):
24+
(WebKit::RemoteMediaSessionCoordinatorProxy::coordinateSetTrack):
25+
(WebKit::RemoteMediaSessionCoordinatorProxy::pauseSession):
26+
(WebKit::RemoteMediaSessionCoordinatorProxy::setSessionTrack):
27+
(WebKit::RemoteMediaSessionCoordinatorProxy::logChannel const):
28+
(WebKit::RemoteMediaSessionCoordinatorProxy::::coordinateSetTrack): Deleted.
29+
* UIProcess/Media/RemoteMediaSessionCoordinatorProxy.h:
30+
(WebKit::RemoteMediaSessionCoordinatorProxy::logger const):
31+
(WebKit::RemoteMediaSessionCoordinatorProxy::logIdentifier const):
32+
(WebKit::RemoteMediaSessionCoordinatorProxy::logClassName const):
33+
134
2021-04-05 Jer Noble <jer.noble@apple.com>
235

336
[Cocoa] Calling AudioComponentFetchServerRegistrations on main thread causes launch time regression
Collapse file

‎Source/WebKit/UIProcess/Media/MediaSessionCoordinatorProxyPrivate.h‎

Copy file name to clipboardExpand all lines: Source/WebKit/UIProcess/Media/MediaSessionCoordinatorProxyPrivate.h
+7-4Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727

2828
#if ENABLE(MEDIA_SESSION_COORDINATOR)
2929

30+
#include <WebCore/ExceptionData.h>
3031
#include <WebCore/MediaSessionCoordinatorPrivate.h>
3132
#include <wtf/RefPtr.h>
3233
#include <wtf/WeakPtr.h>
@@ -41,10 +42,12 @@ class MediaSessionCoordinatorProxyPrivate
4142

4243
virtual String identifier() const = 0;
4344

44-
virtual void seekTo(double, CompletionHandler<void(const WebCore::ExceptionData&)>&&) = 0;
45-
virtual void play(CompletionHandler<void(const WebCore::ExceptionData&)>&&) = 0;
46-
virtual void pause(CompletionHandler<void(const WebCore::ExceptionData&)>&&) = 0;
47-
virtual void setTrack(const String&, CompletionHandler<void(const WebCore::ExceptionData&)>&&) = 0;
45+
virtual void join(CompletionHandler<void(Optional<WebCore::ExceptionData>&&)>&&) = 0;
46+
virtual void leave() = 0;
47+
virtual void seekTo(double, CompletionHandler<void(Optional<WebCore::ExceptionData>&&)>&&) = 0;
48+
virtual void play(CompletionHandler<void(Optional<WebCore::ExceptionData>&&)>&&) = 0;
49+
virtual void pause(CompletionHandler<void(Optional<WebCore::ExceptionData>&&)>&&) = 0;
50+
virtual void setTrack(const String&, CompletionHandler<void(Optional<WebCore::ExceptionData>&&)>&&) = 0;
4851

4952
virtual void positionStateChanged(const Optional<WebCore::MediaPositionState>&) = 0;
5053
virtual void readyStateChanged(WebCore::MediaSessionReadyState) = 0;
Collapse file

‎Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp‎

Copy file name to clipboardExpand all lines: Source/WebKit/UIProcess/Media/RemoteMediaSessionCoordinatorProxy.cpp
+30-14Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,25 +30,34 @@
3030

3131
#include "MediaSessionCoordinatorProxyPrivate.h"
3232
#include "RemoteMediaSessionCoordinatorMessages.h"
33+
#include "RemoteMediaSessionCoordinatorProxyMessages.h"
3334
#include "WebPageProxy.h"
3435
#include "WebProcessProxy.h"
3536
#include <WebCore/ExceptionData.h>
37+
#include <wtf/Logger.h>
38+
#include <wtf/LoggerHelper.h>
3639
#include <wtf/MainThread.h>
3740
#include <wtf/RunLoop.h>
3841

42+
namespace WebCore {
43+
extern WTFLogChannel LogMedia;
44+
}
45+
3946
namespace WebKit {
4047
using namespace WebCore;
4148

42-
RefPtr<RemoteMediaSessionCoordinatorProxy> RemoteMediaSessionCoordinatorProxy::create(WebPageProxy& webPageProxy, Ref<MediaSessionCoordinatorProxyPrivate>&& privateCoordinator)
49+
Ref<RemoteMediaSessionCoordinatorProxy> RemoteMediaSessionCoordinatorProxy::create(WebPageProxy& webPageProxy, Ref<MediaSessionCoordinatorProxyPrivate>&& privateCoordinator)
4350
{
4451
return adoptRef(*new RemoteMediaSessionCoordinatorProxy(webPageProxy, WTFMove(privateCoordinator)));
4552
}
4653

4754
RemoteMediaSessionCoordinatorProxy::RemoteMediaSessionCoordinatorProxy(WebPageProxy& webPageProxy, Ref<MediaSessionCoordinatorProxyPrivate>&& privateCoordinator)
4855
: m_webPageProxy(webPageProxy)
4956
, m_privateCoordinator(WTFMove(privateCoordinator))
57+
#if !RELEASE_LOG_DISABLED
5058
, m_logger(m_webPageProxy.logger())
51-
, m_logIdentifier(uniqueLogIdentifier())
59+
, m_logIdentifier(LoggerHelper::uniqueLogIdentifier())
60+
#endif
5261
{
5362
m_webPageProxy.process().addMessageReceiver(Messages::RemoteMediaSessionCoordinatorProxy::messageReceiverName(), m_webPageProxy.webPageID(), *this);
5463
}
@@ -58,12 +67,12 @@ RemoteMediaSessionCoordinatorProxy::~RemoteMediaSessionCoordinatorProxy()
5867
m_webPageProxy.process().removeMessageReceiver(Messages::RemoteMediaSessionCoordinatorProxy::messageReceiverName(), m_webPageProxy.webPageID());
5968
}
6069

61-
void RemoteMediaSessionCoordinatorProxy::join(CompletionHandler<void(const WebCore::ExceptionData&)>&&)
70+
void RemoteMediaSessionCoordinatorProxy::join(CommandCompletionHandler&& completionHandler)
6271
{
6372
auto identifier = LOGIDENTIFIER;
6473
ALWAYS_LOG(identifier);
6574

66-
m_privateCoordinator->join([identifier] (const WebCore::ExceptionData&& exception) mutable {
75+
m_privateCoordinator->join([this, protectedThis = makeRef(*this), identifier, completionHandler = WTFMove(completionHandler)] (Optional<ExceptionData>&& exception) mutable {
6776
ALWAYS_LOG(identifier, "completion");
6877
completionHandler(WTFMove(exception));
6978
});
@@ -76,45 +85,45 @@ void RemoteMediaSessionCoordinatorProxy::leave()
7685
m_privateCoordinator->leave();
7786
}
7887

79-
void RemoteMediaSessionCoordinatorProxy::coordinateSeekTo(double time, CompletionHandler<void(const WebCore::ExceptionData&)>&& completionHandler)
88+
void RemoteMediaSessionCoordinatorProxy::coordinateSeekTo(double time, CommandCompletionHandler&& completionHandler)
8089
{
8190
auto identifier = LOGIDENTIFIER;
8291
ALWAYS_LOG(identifier, time);
8392

84-
m_privateCoordinator->seekTo(time, [identifier] (const WebCore::ExceptionData&& exception) mutable {
93+
m_privateCoordinator->seekTo(time, [this, protectedThis = makeRef(*this), identifier, completionHandler = WTFMove(completionHandler)] (Optional<ExceptionData>&& exception) mutable {
8594
ALWAYS_LOG(identifier, "completion");
8695
completionHandler(WTFMove(exception));
8796
});
8897
}
8998

90-
void RemoteMediaSessionCoordinatorProxy::coordinatePlay(CompletionHandler<void(const WebCore::ExceptionData&)>&& completionHandler)
99+
void RemoteMediaSessionCoordinatorProxy::coordinatePlay(CommandCompletionHandler&& completionHandler)
91100
{
92101
auto identifier = LOGIDENTIFIER;
93102
ALWAYS_LOG(identifier);
94103

95-
m_privateCoordinator->play([identifier] (const WebCore::ExceptionData&& exception) mutable {
104+
m_privateCoordinator->play([this, protectedThis = makeRef(*this), identifier, completionHandler = WTFMove(completionHandler)] (Optional<ExceptionData>&& exception) mutable {
96105
ALWAYS_LOG(identifier, "completion");
97106
completionHandler(WTFMove(exception));
98107
});
99108
}
100109

101-
void RemoteMediaSessionCoordinatorProxy::coordinatePause(CompletionHandler<void(const WebCore::ExceptionData&)>&& completionHandler)
110+
void RemoteMediaSessionCoordinatorProxy::coordinatePause(CommandCompletionHandler&& completionHandler)
102111
{
103112
auto identifier = LOGIDENTIFIER;
104113
ALWAYS_LOG(identifier);
105114

106-
m_privateCoordinator->pause([identifier] (const WebCore::ExceptionData&& exception) mutable {
115+
m_privateCoordinator->pause([this, protectedThis = makeRef(*this), identifier, completionHandler = WTFMove(completionHandler)] (Optional<ExceptionData>&& exception) mutable {
107116
ALWAYS_LOG(identifier, "completion");
108117
completionHandler(WTFMove(exception));
109118
});
110119
}
111120

112-
void RemoteMediaSessionCoordinatorProxy::::coordinateSetTrack(const String& track, CompletionHandler<void(const WebCore::ExceptionData&)>&& completionHandler)
121+
void RemoteMediaSessionCoordinatorProxy::coordinateSetTrack(const String& track, CommandCompletionHandler&& completionHandler)
113122
{
114123
auto identifier = LOGIDENTIFIER;
115124
ALWAYS_LOG(identifier);
116125

117-
m_privateCoordinator->setTrack(track, [identifier] (const WebCore::ExceptionData&& exception) mutable {
126+
m_privateCoordinator->setTrack(track, [this, protectedThis = makeRef(*this), identifier, completionHandler = WTFMove(completionHandler)] (Optional<ExceptionData>&& exception) mutable {
118127
ALWAYS_LOG(identifier, "completion");
119128
completionHandler(WTFMove(exception));
120129
});
@@ -148,12 +157,12 @@ void RemoteMediaSessionCoordinatorProxy::playSession(CompletionHandler<void(bool
148157
m_webPageProxy.sendWithAsyncReply(Messages::RemoteMediaSessionCoordinator::PlaySession { }, callback);
149158
}
150159

151-
void RemoteMediaSessionCoordinatorProxy::pauseSession(CompletionHandler<void(bool)> callback)
160+
void RemoteMediaSessionCoordinatorProxy::pauseSession(CompletionHandler<void(bool)>&& callback)
152161
{
153162
m_webPageProxy.sendWithAsyncReply(Messages::RemoteMediaSessionCoordinator::PauseSession { }, callback);
154163
}
155164

156-
void RemoteMediaSessionCoordinatorProxy::setSessionTrack(const String& trackId, CompletionHandler<void(bool)> callback)
165+
void RemoteMediaSessionCoordinatorProxy::setSessionTrack(const String& trackId, CompletionHandler<void(bool)>&& callback)
157166
{
158167
m_webPageProxy.sendWithAsyncReply(Messages::RemoteMediaSessionCoordinator::SetSessionTrack { trackId }, callback);
159168
}
@@ -164,6 +173,13 @@ void RemoteMediaSessionCoordinatorProxy::coordinatorStateChanged(WebCore::MediaS
164173
m_privateCoordinator->coordinatorStateChanged(state);
165174
}
166175

176+
#if !RELEASE_LOG_DISABLED
177+
WTFLogChannel& RemoteMediaSessionCoordinatorProxy::logChannel() const
178+
{
179+
return LogMedia;
180+
}
181+
#endif
182+
167183
} // namespace WebKit
168184

169185
#endif // ENABLE(MEDIA_SESSION_COORDINATOR)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.