Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fc47329

Browse filesBrowse files
committed
PR feedback for abstract keyword occurrences
1 parent 758abff commit fc47329
Copy full SHA for fc47329

2 files changed

+9-6Lines changed: 9 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/services/services.ts‎

Copy file name to clipboardExpand all lines: src/services/services.ts
+2-1Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4694,7 +4694,8 @@ namespace ts {
46944694
if (!(container.kind === SyntaxKind.ModuleBlock || container.kind === SyntaxKind.SourceFile)) {
46954695
return undefined;
46964696
}
4697-
} else if (modifier === SyntaxKind.AbstractKeyword) {
4697+
}
4698+
else if (modifier === SyntaxKind.AbstractKeyword) {
46984699
if (!(container.kind === SyntaxKind.ClassDeclaration || declaration.kind === SyntaxKind.ClassDeclaration)) {
46994700
return undefined;
47004701
}
Collapse file

‎tests/cases/fourslash/getOccurrencesAbstract.ts‎

Copy file name to clipboardExpand all lines: tests/cases/fourslash/getOccurrencesAbstract.ts
+7-5Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,13 @@
1010
//// abstract bar(): void;
1111
////}
1212

13-
test.ranges().forEach(r => {
13+
const ranges = test.ranges();
14+
15+
for(let r of ranges) {
1416
goTo.position(r.start);
15-
verify.occurrencesAtPositionCount(test.ranges().length);
17+
verify.occurrencesAtPositionCount(ranges.length);
1618

17-
test.ranges().forEach(range => {
19+
for(let range of ranges) {
1820
verify.occurrencesAtPositionContains(range, false);
19-
});
20-
});
21+
}
22+
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.