Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e6bcef7

Browse filesBrowse files
committed
Combining unknown type+value symbol->unknownSymbol
Previously, when getExternalModuleMember tried to combine unknownSymbol from a type and unknownSymbol from a value, it combineValueAndTypeSymbol would create a new franken-symbol that was no longer equal to unknownSymbol.
1 parent 928da67 commit e6bcef7
Copy full SHA for e6bcef7

1 file changed

+3Lines changed: 3 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/compiler/checker.ts‎

Copy file name to clipboardExpand all lines: src/compiler/checker.ts
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1364,6 +1364,9 @@ namespace ts {
13641364
// An 'import { Point } from "graphics"' needs to create a symbol that combines the value side 'Point'
13651365
// property with the type/namespace side interface 'Point'.
13661366
function combineValueAndTypeSymbols(valueSymbol: Symbol, typeSymbol: Symbol): Symbol {
1367+
if (valueSymbol === unknownSymbol && typeSymbol === unknownSymbol) {
1368+
return unknownSymbol;
1369+
}
13671370
if (valueSymbol.flags & (SymbolFlags.Type | SymbolFlags.Namespace)) {
13681371
return valueSymbol;
13691372
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.