Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit db3696c

Browse filesBrowse files
sandersnsandersn
committed
Test:retain undefined in spreads w/strictNullChecks
Add test case and update baselines with new errors
1 parent b9efe3e commit db3696c
Copy full SHA for db3696c

3 files changed

+105Lines changed: 105 additions & 0 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎tests/baselines/reference/objectSpreadStrictNull.errors.txt‎

Copy file name to clipboard
+84Lines changed: 84 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,84 @@
1+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(9,9): error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number; }'.
2+
Types of property 'sn' are incompatible.
3+
Type 'string | number | undefined' is not assignable to type 'string | number'.
4+
Type 'undefined' is not assignable to type 'string | number'.
5+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(10,9): error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number; }'.
6+
Types of property 'sn' are incompatible.
7+
Type 'string | number | undefined' is not assignable to type 'string | number'.
8+
Type 'undefined' is not assignable to type 'string | number'.
9+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(14,9): error TS2322: Type '{ sn: number | undefined; }' is not assignable to type '{ sn: string | number; }'.
10+
Types of property 'sn' are incompatible.
11+
Type 'number | undefined' is not assignable to type 'string | number'.
12+
Type 'undefined' is not assignable to type 'string | number'.
13+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(15,9): error TS2322: Type '{ sn: number | undefined; }' is not assignable to type '{ sn: string | number; }'.
14+
Types of property 'sn' are incompatible.
15+
Type 'number | undefined' is not assignable to type 'string | number'.
16+
Type 'undefined' is not assignable to type 'string | number'.
17+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(18,9): error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number | boolean; }'.
18+
Types of property 'sn' are incompatible.
19+
Type 'string | number | undefined' is not assignable to type 'string | number | boolean'.
20+
Type 'undefined' is not assignable to type 'string | number | boolean'.
21+
tests/cases/conformance/types/spread/objectSpreadStrictNull.ts(28,7): error TS2322: Type '{ title: undefined; yearReleased: number; }' is not assignable to type 'Movie'.
22+
Types of property 'title' are incompatible.
23+
Type 'undefined' is not assignable to type 'string'.
24+
25+
26+
==== tests/cases/conformance/types/spread/objectSpreadStrictNull.ts (6 errors) ====
27+
function f(
28+
definiteBoolean: { sn: boolean },
29+
definiteString: { sn: string },
30+
optionalString: { sn?: string },
31+
optionalNumber: { sn?: number },
32+
undefinedString: { sn: string | undefined },
33+
undefinedNumber: { sn: number | undefined }) {
34+
// optional
35+
let optionalUnionStops: { sn: string | number } = { ...definiteBoolean, ...definiteString, ...optionalNumber };
36+
~~~~~~~~~~~~~~~~~~
37+
!!! error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number; }'.
38+
!!! error TS2322: Types of property 'sn' are incompatible.
39+
!!! error TS2322: Type 'string | number | undefined' is not assignable to type 'string | number'.
40+
!!! error TS2322: Type 'undefined' is not assignable to type 'string | number'.
41+
let optionalUnionDuplicates: { sn: string | number } = { ...definiteBoolean, ...definiteString, ...optionalString, ...optionalNumber };
42+
~~~~~~~~~~~~~~~~~~~~~~~
43+
!!! error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number; }'.
44+
!!! error TS2322: Types of property 'sn' are incompatible.
45+
!!! error TS2322: Type 'string | number | undefined' is not assignable to type 'string | number'.
46+
!!! error TS2322: Type 'undefined' is not assignable to type 'string | number'.
47+
let allOptional: { sn?: string | number } = { ...optionalString, ...optionalNumber };
48+
49+
// undefined
50+
let undefinedUnionStops: { sn: string | number } = { ...definiteBoolean, ...definiteString, ...undefinedNumber };
51+
~~~~~~~~~~~~~~~~~~~
52+
!!! error TS2322: Type '{ sn: number | undefined; }' is not assignable to type '{ sn: string | number; }'.
53+
!!! error TS2322: Types of property 'sn' are incompatible.
54+
!!! error TS2322: Type 'number | undefined' is not assignable to type 'string | number'.
55+
!!! error TS2322: Type 'undefined' is not assignable to type 'string | number'.
56+
let undefinedUnionDuplicates: { sn: string | number } = { ...definiteBoolean, ...definiteString, ...undefinedString, ...undefinedNumber };
57+
~~~~~~~~~~~~~~~~~~~~~~~~
58+
!!! error TS2322: Type '{ sn: number | undefined; }' is not assignable to type '{ sn: string | number; }'.
59+
!!! error TS2322: Types of property 'sn' are incompatible.
60+
!!! error TS2322: Type 'number | undefined' is not assignable to type 'string | number'.
61+
!!! error TS2322: Type 'undefined' is not assignable to type 'string | number'.
62+
let allUndefined: { sn: string | number | undefined } = { ...undefinedString, ...undefinedNumber };
63+
64+
let undefinedWithOptionalContinues: { sn: string | number | boolean } = { ...definiteBoolean, ...undefinedString, ...optionalNumber };
65+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
66+
!!! error TS2322: Type '{ sn: string | number | undefined; }' is not assignable to type '{ sn: string | number | boolean; }'.
67+
!!! error TS2322: Types of property 'sn' are incompatible.
68+
!!! error TS2322: Type 'string | number | undefined' is not assignable to type 'string | number | boolean'.
69+
!!! error TS2322: Type 'undefined' is not assignable to type 'string | number | boolean'.
70+
}
71+
72+
type Movie = {
73+
title: string;
74+
yearReleased: number;
75+
}
76+
77+
const m = { title: "The Matrix", yearReleased: 1999 };
78+
// should error here because title: undefined is not assignable to string
79+
const x: Movie = { ...m, title: undefined };
80+
~
81+
!!! error TS2322: Type '{ title: undefined; yearReleased: number; }' is not assignable to type 'Movie'.
82+
!!! error TS2322: Types of property 'title' are incompatible.
83+
!!! error TS2322: Type 'undefined' is not assignable to type 'string'.
84+
Collapse file

‎tests/baselines/reference/objectSpreadStrictNull.js‎

Copy file name to clipboardExpand all lines: tests/baselines/reference/objectSpreadStrictNull.js
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,15 @@ function f(
1818

1919
let undefinedWithOptionalContinues: { sn: string | number | boolean } = { ...definiteBoolean, ...undefinedString, ...optionalNumber };
2020
}
21+
22+
type Movie = {
23+
title: string;
24+
yearReleased: number;
25+
}
26+
27+
const m = { title: "The Matrix", yearReleased: 1999 };
28+
// should error here because title: undefined is not assignable to string
29+
const x: Movie = { ...m, title: undefined };
2130

2231

2332
//// [objectSpreadStrictNull.js]
@@ -40,3 +49,6 @@ function f(definiteBoolean, definiteString, optionalString, optionalNumber, unde
4049
var allUndefined = __assign({}, undefinedString, undefinedNumber);
4150
var undefinedWithOptionalContinues = __assign({}, definiteBoolean, undefinedString, optionalNumber);
4251
}
52+
var m = { title: "The Matrix", yearReleased: 1999 };
53+
// should error here because title: undefined is not assignable to string
54+
var x = __assign({}, m, { title: undefined });
Collapse file

‎tests/cases/conformance/types/spread/objectSpreadStrictNull.ts‎

Copy file name to clipboardExpand all lines: tests/cases/conformance/types/spread/objectSpreadStrictNull.ts
+9Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,12 @@ function f(
1919

2020
let undefinedWithOptionalContinues: { sn: string | number | boolean } = { ...definiteBoolean, ...undefinedString, ...optionalNumber };
2121
}
22+
23+
type Movie = {
24+
title: string;
25+
yearReleased: number;
26+
}
27+
28+
const m = { title: "The Matrix", yearReleased: 1999 };
29+
// should error here because title: undefined is not assignable to string
30+
const x: Movie = { ...m, title: undefined };

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.