Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit 7f577dc

Browse filesBrowse files
author
Armando Aguirre
committed
Added triple slash support
1 parent f8ccde5 commit 7f577dc
Copy full SHA for 7f577dc

5 files changed

+14-8Lines changed: 14 additions & 8 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/services/goToDefinition.ts‎

Copy file name to clipboardExpand all lines: src/services/goToDefinition.ts
+10-4Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -156,10 +156,16 @@ namespace ts.GoToDefinition {
156156
return undefined;
157157
}
158158

159-
// TODO: Add textSpan for triple slash references (file and type).
160-
const comment = findReferenceInPosition(sourceFile.referencedFiles, position);
161-
if (comment && tryResolveScriptReference(program, sourceFile, comment) || findReferenceInPosition(sourceFile.typeReferenceDirectives, position)) {
162-
return { definitions, textSpan: undefined };
159+
let comment = findReferenceInPosition(sourceFile.referencedFiles, position);
160+
if (!comment || !tryResolveScriptReference(program, sourceFile, comment)) {
161+
comment = findReferenceInPosition(sourceFile.typeReferenceDirectives, position);
162+
}
163+
164+
if (comment) {
165+
return {
166+
definitions,
167+
textSpan: createTextSpanFromBounds(comment.pos, comment.end)
168+
};
163169
}
164170

165171
const node = getTouchingPropertyName(sourceFile, position, /*includeJsDocComment*/ true);
Collapse file

‎tests/cases/fourslash/goToDefinitionSourceUnit.ts‎

Copy file name to clipboardExpand all lines: tests/cases/fourslash/goToDefinitionSourceUnit.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
//// //MyFile Comments
55
//// //more comments
66
//// /// <reference path="so/*unknownFile*/mePath.ts" />
7-
//// /// <reference path="b/*knownFile*/.ts" />
7+
//// /// <reference path="[|b/*knownFile*/.ts|]" />
88
////
99
//// class clsInOverload {
1010
//// static fnOverload();
Collapse file

‎tests/cases/fourslash/goToDefinitionTypeReferenceDirective.ts‎

Copy file name to clipboardExpand all lines: tests/cases/fourslash/goToDefinitionTypeReferenceDirective.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/////*0*/declare let $: {x: number};
66

77
// @Filename: src/app.ts
8-
//// /// <reference types="lib/*1*/"/>
8+
//// /// <reference types="[|lib/*1*/|]"/>
99
//// $.x;
1010

1111
verify.goToDefinition("1", "0");
Collapse file

‎tests/cases/fourslash/shims-pp/goToDefinitionTypeReferenceDirective.ts‎

Copy file name to clipboardExpand all lines: tests/cases/fourslash/shims-pp/goToDefinitionTypeReferenceDirective.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/////*0*/declare let $: {x: number};
66

77
// @Filename: src/app.ts
8-
//// /// <reference types="lib/*1*/"/>
8+
//// /// <reference types="[|lib/*1*/|]"/>
99
//// $.x;
1010

1111
verify.goToDefinition("1", "0");
Collapse file

‎tests/cases/fourslash/shims/goToDefinitionTypeReferenceDirective.ts‎

Copy file name to clipboardExpand all lines: tests/cases/fourslash/shims/goToDefinitionTypeReferenceDirective.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
/////*0*/declare let $: {x: number};
66

77
// @Filename: src/app.ts
8-
//// /// <reference types="lib/*1*/"/>
8+
//// /// <reference types="[|lib/*1*/|]"/>
99
//// $.x;
1010

1111
verify.goToDefinition("1", "0");

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.