Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 71ceb91

Browse filesBrowse files
authored
Parallel runner shouldnt print nan and freeze on unestimatable tests when above batch count (microsoft#20176)
1 parent 2c8e49f commit 71ceb91
Copy full SHA for 71ceb91

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/harness/parallel/host.ts‎

Copy file name to clipboardExpand all lines: src/harness/parallel/host.ts
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,8 +208,8 @@ namespace Harness.Parallel.Host {
208208
workers.push(child);
209209
}
210210

211-
// It's only really worth doing an initial batching if there are a ton of files to go through
212-
if (totalFiles > 1000) {
211+
// It's only really worth doing an initial batching if there are a ton of files to go through (and they have estimates)
212+
if (totalFiles > 1000 && batchSize > 0) {
213213
console.log("Batching initial test lists...");
214214
const batches: { runner: TestRunnerKind | "unittest", file: string, size: number }[][] = new Array(batchCount);
215215
const doneBatching = new Array(batchCount);

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.