Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 3b6da51

Browse filesBrowse files
committed
remove TODO's
1 parent 7e03429 commit 3b6da51
Copy full SHA for 3b6da51

4 files changed

+2-6Lines changed: 2 additions & 6 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎src/compiler/utilities.ts‎

Copy file name to clipboardExpand all lines: src/compiler/utilities.ts
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4482,7 +4482,7 @@ namespace ts {
44824482
newEndN = Math.max(newEnd2, newEnd2 + (newEnd1 - oldEnd2));
44834483
}
44844484

4485-
return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength:*/ newEndN - oldStartN);
4485+
return createTextChangeRange(createTextSpanFromBounds(oldStartN, oldEndN), /*newLength*/ newEndN - oldStartN);
44864486
}
44874487

44884488
export function getTypeParameterOwner(d: Declaration): Declaration {
Collapse file

‎src/harness/fourslash.ts‎

Copy file name to clipboardExpand all lines: src/harness/fourslash.ts
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2897,7 +2897,6 @@ ${code}
28972897
}
28982898
}
28992899
}
2900-
// TODO: should be '==='?
29012900
}
29022901
else if (line === "" || lineLength === 0) {
29032902
// Previously blank lines between fourslash content caused it to be considered as 2 files,
Collapse file

‎src/harness/projectsRunner.ts‎

Copy file name to clipboardExpand all lines: src/harness/projectsRunner.ts
-1Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ class ProjectRunner extends RunnerBase {
111111
else if (url.indexOf(diskProjectPath) === 0) {
112112
// Replace the disk specific path into the project root path
113113
url = url.substr(diskProjectPath.length);
114-
// TODO: should be '!=='?
115114
if (url.charCodeAt(0) !== ts.CharacterCodes.slash) {
116115
url = "/" + url;
117116
}
Collapse file

‎src/services/shims.ts‎

Copy file name to clipboardExpand all lines: src/services/shims.ts
+1-3Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ namespace ts {
3737
*
3838
* Or undefined value if there was no change.
3939
*/
40-
getChangeRange(oldSnapshot: ScriptSnapshotShim): string;
40+
getChangeRange(oldSnapshot: ScriptSnapshotShim): string | undefined;
4141

4242
/** Releases all resources held by this script snapshot */
4343
dispose?(): void;
@@ -292,7 +292,6 @@ namespace ts {
292292
public getChangeRange(oldSnapshot: IScriptSnapshot): TextChangeRange {
293293
const oldSnapshotShim = <ScriptSnapshotShimAdapter>oldSnapshot;
294294
const encoded = this.scriptSnapshotShim.getChangeRange(oldSnapshotShim.scriptSnapshotShim);
295-
// TODO: should this be '==='?
296295
if (encoded === null) {
297296
return null;
298297
}
@@ -381,7 +380,6 @@ namespace ts {
381380

382381
public getCompilationSettings(): CompilerOptions {
383382
const settingsJson = this.shimHost.getCompilationSettings();
384-
// TODO: should this be '==='?
385383
if (settingsJson === null || settingsJson === "") {
386384
throw Error("LanguageServiceShimHostAdapter.getCompilationSettings: empty compilationSettings");
387385
}

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.