File tree Expand file tree Collapse file tree
Open diff view settings
Expand file tree Collapse file tree
Open diff view settings
Original file line number Diff line number Diff line change @@ -4482,7 +4482,7 @@ namespace ts {
44824482 newEndN = Math . max ( newEnd2 , newEnd2 + ( newEnd1 - oldEnd2 ) ) ;
44834483 }
44844484
4485- return createTextChangeRange ( createTextSpanFromBounds ( oldStartN , oldEndN ) , /*newLength: */ newEndN - oldStartN ) ;
4485+ return createTextChangeRange ( createTextSpanFromBounds ( oldStartN , oldEndN ) , /*newLength*/ newEndN - oldStartN ) ;
44864486 }
44874487
44884488 export function getTypeParameterOwner ( d : Declaration ) : Declaration {
Original file line number Diff line number Diff line change @@ -2897,7 +2897,6 @@ ${code}
28972897 }
28982898 }
28992899 }
2900- // TODO: should be '==='?
29012900 }
29022901 else if ( line === "" || lineLength === 0 ) {
29032902 // Previously blank lines between fourslash content caused it to be considered as 2 files,
Original file line number Diff line number Diff line change @@ -111,7 +111,6 @@ class ProjectRunner extends RunnerBase {
111111 else if ( url . indexOf ( diskProjectPath ) === 0 ) {
112112 // Replace the disk specific path into the project root path
113113 url = url . substr ( diskProjectPath . length ) ;
114- // TODO: should be '!=='?
115114 if ( url . charCodeAt ( 0 ) !== ts . CharacterCodes . slash ) {
116115 url = "/" + url ;
117116 }
Original file line number Diff line number Diff line change @@ -37,7 +37,7 @@ namespace ts {
3737 *
3838 * Or undefined value if there was no change.
3939 */
40- getChangeRange ( oldSnapshot : ScriptSnapshotShim ) : string ;
40+ getChangeRange ( oldSnapshot : ScriptSnapshotShim ) : string | undefined ;
4141
4242 /** Releases all resources held by this script snapshot */
4343 dispose ?( ) : void ;
@@ -292,7 +292,6 @@ namespace ts {
292292 public getChangeRange ( oldSnapshot : IScriptSnapshot ) : TextChangeRange {
293293 const oldSnapshotShim = < ScriptSnapshotShimAdapter > oldSnapshot ;
294294 const encoded = this . scriptSnapshotShim . getChangeRange ( oldSnapshotShim . scriptSnapshotShim ) ;
295- // TODO: should this be '==='?
296295 if ( encoded === null ) {
297296 return null ;
298297 }
@@ -381,7 +380,6 @@ namespace ts {
381380
382381 public getCompilationSettings ( ) : CompilerOptions {
383382 const settingsJson = this . shimHost . getCompilationSettings ( ) ;
384- // TODO: should this be '==='?
385383 if ( settingsJson === null || settingsJson === "" ) {
386384 throw Error ( "LanguageServiceShimHostAdapter.getCompilationSettings: empty compilationSettings" ) ;
387385 }
You can’t perform that action at this time.
0 commit comments