Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit fe26fe7

Browse filesBrowse files
committed
add testing for medium and large bytecode layout to nightly config
1 parent 0cd97b1 commit fe26fe7
Copy full SHA for fe26fe7

3 files changed

+43-2Lines changed: 43 additions & 2 deletions

File tree

Expand file treeCollapse file tree
Open diff view settings
Filter options
Expand file treeCollapse file tree
Open diff view settings
Collapse file

‎Build/Chakra.Build.props‎

Copy file name to clipboardExpand all lines: Build/Chakra.Build.props
+4Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,10 @@
2424
%(PreprocessorDefinitions);
2525
DISABLE_JIT=1
2626
</PreprocessorDefinitions>
27+
<PreprocessorDefinitions Condition="'$(ENABLE_CODECOVERAGE)'=='true'">
28+
%(PreprocessorDefinitions);
29+
BYTECODE_TESTING=1
30+
</PreprocessorDefinitions>
2731
<!-- REVIEW: These are warning are introduced when moving to VS2015 tools, may want to clean these up -->
2832
<DisableSpecificWarnings>
2933
%(DisableSpecificWarnings);
Collapse file

‎test/Function/rlexe.xml‎

Copy file name to clipboardExpand all lines: test/Function/rlexe.xml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@
325325
<files>FuncBody.bug231397.js</files>
326326
<baseline>FuncBody.bug231397.baseline</baseline>
327327
<compile-flags>-dump:bytecode</compile-flags>
328-
<tags>exclude_fre,require_backend</tags>
328+
<tags>exclude_bytecodelayout,exclude_fre,require_backend</tags>
329329
</default>
330330
</test>
331331
<test>
Collapse file

‎test/runtests.cmd‎

Copy file name to clipboardExpand all lines: test/runtests.cmd
+38-1Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,6 @@ goto :main
163163
if /i "%1" == "-quiet" set _quiet=-quiet& goto :ArgOk
164164
:: TODO Consider removing -drt and exclude_drt in some reasonable manner
165165
if /i "%1" == "-drt" set _drt=1& set _NOTTAGS=%_NOTTAGS% -nottags:exclude_drt& goto :ArgOk
166-
if /i "%1" == "-nightly" set _nightly=1& goto :ArgOk
167166
if /i "%1" == "-rebase" set _rebase=-rebase& goto :ArgOk
168167
if /i "%1" == "-rundebug" set _RUNDEBUG=1& goto :ArgOk
169168
:: TODO Figure out best way to specify build arch for tests that are excluded to specific archs
@@ -212,6 +211,16 @@ goto :main
212211
set _Variants=disable_jit
213212
goto :ArgOk
214213
)
214+
215+
if /i "%1" == "-nightly" (
216+
set _nightly=1
217+
if "%_ExtraVariants%" == "" (
218+
set _ExtraVariants=mediumlayout,largelayout,forceserialized
219+
) else (
220+
set _ExtraVariants=%_ExtraVariants%,mediumlayout,largelayout,forceserialized
221+
)
222+
goto :ArgOk
223+
)
215224

216225
if not "%1" == "" echo Unknown argument: %1 & set fShowGetHelp=1
217226

@@ -344,6 +353,24 @@ goto :main
344353
:: ============================================================================
345354
:RunOneVariant
346355

356+
if "%_BuildType%" == "test" (
357+
rem bytecode layout switches not available in test build
358+
if "%_TESTCONFIG%"=="largelayout" (
359+
if not exist %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG% (
360+
mkdir %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG%
361+
)
362+
echo. > %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG%\rl.log
363+
goto :eof
364+
)
365+
if "%_TESTCONFIG%"=="mediumlayout" (
366+
if not exist %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG% (
367+
mkdir %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG%
368+
)
369+
echo. > %_logsRoot%\%_BuildArch%_%_BuildType%\%_TESTCONFIG%\rl.log
370+
goto :eof
371+
)
372+
)
373+
347374
set _OLD_CC_FLAGS=%EXTRA_CC_FLAGS%
348375
set EXTRA_RL_FLAGS=-appendtestnametoextraccflags
349376
set _exclude_serialized=
@@ -407,6 +434,16 @@ goto :main
407434
set EXTRA_RL_FLAGS=
408435
set _exclude_serialized=-nottags:exclude_serialized
409436
)
437+
if "%_TESTCONFIG%"=="mediumlayout" (
438+
set EXTRA_CC_FLAGS=%EXTRA_CC_FLAGS% -MediumByteCodeLayout -forceserialized
439+
set EXTRA_RL_FLAGS=-nottags:exclude_bytecodelayout
440+
set _exclude_serialized=-nottags:exclude_serialized
441+
)
442+
if "%_TESTCONFIG%"=="largelayout" (
443+
set EXTRA_CC_FLAGS=%EXTRA_CC_FLAGS% -LargeByteCodeLayout -forceserialized
444+
set EXTRA_RL_FLAGS=-nottags:exclude_bytecodelayout
445+
set _exclude_serialized=-nottags:exclude_serialized
446+
)
410447

411448
echo.
412449
echo ############# Starting %_TESTCONFIG% variant #############

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.