Remove trailing commas from yaml config - #58
#58Open
rpuch wants to merge 1 commit into
JanusGraph:masterJanusGraph/janusgraph-foundationdb:masterfrom
rpuch:remove-trailing-commas-from-yaml-configrpuch/janusgraph-foundationdb:remove-trailing-commas-from-yaml-configCopy head branch name to clipboard
Open
Remove trailing commas from yaml config#58rpuch wants to merge 1 commit intoJanusGraph:masterJanusGraph/janusgraph-foundationdb:masterfrom rpuch:remove-trailing-commas-from-yaml-configrpuch/janusgraph-foundationdb:remove-trailing-commas-from-yaml-configCopy head branch name to clipboard
rpuch wants to merge 1 commit into
JanusGraph:masterJanusGraph/janusgraph-foundationdb:masterfrom
rpuch:remove-trailing-commas-from-yaml-configrpuch/janusgraph-foundationdb:remove-trailing-commas-from-yaml-configCopy head branch name to clipboard
Conversation
|
|
Contributor
|
Hi @rpuch, thanks for your contribution! |
Because this breaks parsing Signed-off-by: Roman Puchkovskiy <roman.puchkovskiy@gmail.com>
rpuch
force-pushed
the
remove-trailing-commas-from-yaml-config
branch
from
March 31, 2021 08:28
e8f2e07 to
f26df2d
Compare
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually, I'm not 100% sure that this is the correct fix to do as, according to
git annotate, these lines are 3 years old, but with JanusGraph-0.5.2 I get the following error when starting the server:Removal of the trailing commas resolved the issue for me.