Fix show_related_resources and top_level_meta_include_page_count#1392
Open
bliof wants to merge 1 commit into
JSONAPI-Resources:masterJSONAPI-Resources/jsonapi-resources:masterfrom
bliof:fix-relationships-without-paginationsbliof/jsonapi-resources:fix-relationships-without-paginationsCopy head branch name to clipboard
Open
Fix show_related_resources and top_level_meta_include_page_count#1392bliof wants to merge 1 commit intoJSONAPI-Resources:masterJSONAPI-Resources/jsonapi-resources:masterfrom bliof:fix-relationships-without-paginationsbliof/jsonapi-resources:fix-relationships-without-paginationsCopy head branch name to clipboard
bliof wants to merge 1 commit into
JSONAPI-Resources:masterJSONAPI-Resources/jsonapi-resources:masterfrom
bliof:fix-relationships-without-paginationsbliof/jsonapi-resources:fix-relationships-without-paginationsCopy head branch name to clipboard
Conversation
problem: When the paginator is :none and top_level_meta_include_page_count is true The show_related_resources was crashing as the paginator is nil solution: Just fixing the immediate problem but the code still leaves page_count as nil in the meta
35ed838 to
4840292
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem:
When the paginator is :none and top_level_meta_include_page_count is true
The show_related_resources was crashing as the paginator is nil
solution:
Just fixing the immediate problem but the code still leaves page_count
as nil in the meta
Reviewer Checklist: