Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Use underscore instead of downcase#1366

Merged
lgebhardt merged 2 commits into
release-0-10JSONAPI-Resources/jsonapi-resources:release-0-10from
polymorphic_downcase_fix_0_10JSONAPI-Resources/jsonapi-resources:polymorphic_downcase_fix_0_10Copy head branch name to clipboard
May 19, 2021
Merged

Use underscore instead of downcase#1366
lgebhardt merged 2 commits into
release-0-10JSONAPI-Resources/jsonapi-resources:release-0-10from
polymorphic_downcase_fix_0_10JSONAPI-Resources/jsonapi-resources:polymorphic_downcase_fix_0_10Copy head branch name to clipboard

Conversation

@lgebhardt

Copy link
Copy Markdown
Contributor

All Submissions:

  • I've checked to ensure there aren't other open Pull Requests for the same update/change.
  • I've submitted a ticket for my issue if one did not already exist.
  • My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
  • I've used Github auto-closing keywords in the commit message or the description.
  • I've added/updated tests for this change.

New Feature Submissions:

  • I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
  • My submission includes new tests.
  • My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

  • I've included an explanation of what the changes do and why I'd like you to include them.
  • I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

  • Maintains compliance with JSON:API
  • Adequate test coverage exists to prevent regressions

@lgebhardt lgebhardt requested a review from dgeb May 19, 2021 15:41
@lgebhardt lgebhardt marked this pull request as draft May 19, 2021 15:46
@lgebhardt lgebhardt force-pushed the polymorphic_downcase_fix_0_10 branch from 8d22280 to eebe859 Compare May 19, 2021 18:30
@lgebhardt lgebhardt force-pushed the polymorphic_downcase_fix_0_10 branch from eebe859 to c175b9b Compare May 19, 2021 20:35
@lgebhardt lgebhardt marked this pull request as ready for review May 19, 2021 20:48
@lgebhardt lgebhardt merged commit ea3ff21 into release-0-10 May 19, 2021
@lgebhardt lgebhardt deleted the polymorphic_downcase_fix_0_10 branch May 19, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.