Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

BUG: Fix compatibility with scikit-build(-core) build directory names#279

Merged
thewtex merged 1 commit into
InsightSoftwareConsortium:masterInsightSoftwareConsortium/ITKPythonPackage:masterfrom
SimonRit:skbuild_buildSimonRit/ITKPythonPackage:skbuild_buildCopy head branch name to clipboard
Jul 8, 2024
Merged

BUG: Fix compatibility with scikit-build(-core) build directory names#279
thewtex merged 1 commit into
InsightSoftwareConsortium:masterInsightSoftwareConsortium/ITKPythonPackage:masterfrom
SimonRit:skbuild_buildSimonRit/ITKPythonPackage:skbuild_buildCopy head branch name to clipboard

Conversation

@SimonRit
Copy link
Copy Markdown

@SimonRit SimonRit commented Jul 7, 2024

scikit-build compiles in the directory "_skbuild/cmake-build"

scikit-build-core compiles in an environment-dependent directory, e.g., in the directory "build/cp38-cp38-manylinux_2_28_x86_64"

scikit-build compiles in the directory "_skbuild/cmake-build"

scikit-build-core compiles in an environment-dependent directory, e.g., in the directory "build/cp38-cp38-manylinux_2_28_x86_64"
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thewtex thewtex merged commit ac32eda into InsightSoftwareConsortium:master Jul 8, 2024
@SimonRit SimonRit deleted the skbuild_build branch July 8, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.