Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

6099 refactor index files - #6349

#6349
Merged
kcondon merged 8 commits into
developIQSS/dataverse:developfrom
6099-refactor-index-filesIQSS/dataverse:6099-refactor-index-filesCopy head branch name to clipboard
Nov 8, 2019
Merged

6099 refactor index files#6349
kcondon merged 8 commits into
developIQSS/dataverse:developfrom
6099-refactor-index-filesIQSS/dataverse:6099-refactor-index-filesCopy head branch name to clipboard

Conversation

@sekmiller

Copy link
Copy Markdown
Contributor

New Contributors

Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.

Thanks for your contribution to Dataverse!

Related Issues

Pull Request Checklist

  • Unit [tests][x] completed
  • Integration tests: None
  • Deployment requirements,None
  • Documentation NA
  • Merged latest from "develop" [branch][x] and resolved conflicts

@coveralls

coveralls commented Nov 6, 2019

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.003%) to 19.464% when pulling 27c6e2e on 6099-refactor-index-files into 5dca95d on develop.

@kcondon kcondon self-assigned this Nov 6, 2019
@djbrooke djbrooke assigned sekmiller and unassigned kcondon Nov 7, 2019
@pdurbin

pdurbin commented Nov 8, 2019

Copy link
Copy Markdown
Member

@sekmiller does 824a27f fix #3842?

@sekmiller

sekmiller commented Nov 8, 2019

Copy link
Copy Markdown
Contributor Author

This should have no effect on #3842. That has to do with indexing draft datasets, this #6099 specifically deals with FILE metadata indexing. (also the intent is not to index more, just index the same amount with consolidated logic.)

@kcondon
kcondon merged commit 41acae1 into develop Nov 8, 2019
@kcondon
kcondon deleted the 6099-refactor-index-files branch November 8, 2019 20:51
@kcondon kcondon assigned kcondon and unassigned sekmiller Nov 8, 2019
@djbrooke djbrooke added this to the 4.18 milestone Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactoring: Have check for whether to index files use same code as version differences

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.