5615 "add data" button on navbar by landreev · Pull Request #6338 · IQSS/dataverse

landreev · Nov 1, 2019

New Contributors

Related Issues

closes Add "Add Data" to navbar, plus Host Dataverse input to create dataverse/dataset forms #5615: add "Add Data" button to the navbar

Pull Request Checklist

Unit tests completed
Integration tests: None
Deployment requirements, SQL updates, Solr updates, etc.: None
Documentation completed
Merged latest from "develop" branch and resolved conflicts

…ader, edit dataverse form [ref #5615]

…ms [ref #5615]

…5615]

…form [ref #5615]

…[ref 5615]

…ab [ref #5615]

…it to edit dataverse pg [ref 5615]

…nd resposnive layout improvements to top metrics/button block of dataverse and dateset pgs [ref #5615]

…ixes [ref #5615, #6162]

…ss changes [ref #5615]

…cumention of Add Data workflows for new navbar and My Data link/button to user guides, fixed misc formatting issues in guides [ref #5615]

… dataverse is selected (#5615)

)

… info msg [ref #5615]

coveralls · Nov 1, 2019

Coverage decreased (-0.01%) to 19.45% when pulling 81020ab on 5615-add-data-navbar into b18f706 on develop.

…r is allowed to add datasets... this is not fully acceptable either, unfortunately (#5615)

…averse (#5615)

…e, dataset forms plus other instances [ref #5615]

…the "edit existing dataverse" mode. (#5615)

…#5615)

…5615)

to top of list since it is at the top of the form now [ref #5615]

…tuning (#5615)

kcondon · Nov 8, 2019

issues:
-on create dataverse, throws server log error with duplicate jsf id error but works.
-initial validation errors (eg. affiliation blank) is not displayed on create likely due to dupe id error halting further processing but works second time. other validation, eg. category may work.
-changing target dataverse for creating dataverse is ignored, always created in root.
-changing target dataverse for creating dataset throws string parsing error in log and UI remains in grayed out/processing state.

…[ref #5615]

…rong owner dataverse on create. (#5615)

…5615)

landreev · Nov 12, 2019

I believe the issues listed above have been fixed. Except for the last one from the list (below) - my recollection is that we were unable to reproduce that one, and that the dataset page was actually working properly. It appears to be functioning correctly now.

-changing target dataverse for creating dataset throws string parsing error in log and UI remains in grayed out/processing state.

mheppler and others added 25 commits October 7, 2019 14:25

Added Add Data dropdown to navbar, plus code cleanup for dataverse he…

8749cb2

…ader, edit dataverse form [ref #5615]

Added rel=noopener

2e49ff0

Additional responsive layout fixes for edit dataverse form [ref 5616]

912427e

Merge branch 'develop' into 5615-add-data-navbar

a673e3e

Returned Host Dataverse component to create dataverse and dataset for…

58d4ee3

…ms [ref #5615]

Fixed label and input references in dataverse and contact forms [ref #…

52ed565

…5615]

Merge branch 'develop' into 5615-add-data-navbar

9973038

Cleaned up code and added accessibility improvements to edit dataset …

e6d4109

…form [ref #5615]

Fixed render logic used for required attributes on edit dataset form …

695a5c1

…[ref 5615]

Added required attribute to edit dataverse form [ref #5615]

8bb1adb

Added Add Data btn to My Data pg, moved Edit Account btn to Account t…

4c48cb6

…ab [ref #5615]

Cleaned up layout of asterisk required msg on edit dataset pg, added …

7054e31

…it to edit dataverse pg [ref 5615]

Improved responsive layout of navbar, styling of language dropdown, a…

c2944ae

…nd resposnive layout improvements to top metrics/button block of dataverse and dateset pgs [ref #5615]

More responsive layout improvements, plus deaccession reason layout f…

fe17457

…ixes [ref #5615, #6162]

Merge branch 'develop' into 5615-add-data-navbar

99817ee

Fixed padding issue with Metrics block on dataverse pg [ref #5615]

c41b8bb

Fixed broken render logic on edit dataset pg from recent responsivene…

305caf0

…ss changes [ref #5615]

Added name to dataverse label on create/edit dataverse form, added do…

e08a3c6

…cumention of Add Data workflows for new navbar and My Data link/button to user guides, fixed misc formatting issues in guides [ref #5615]

Merge branch 'develop' into 5615-add-data-navbar

745ceed

added code for dataverse/dataset page updates when a new host (owner)…

c71be81

… dataverse is selected (#5615)

fixed the breadcrumb display (#5615)

bec5ddf

fixed the breadcrumb display (#5615)

51a886f

faster/less memory hoggish dataverse menu list via a native query (#5615

39b3789

)

Moved host dataverse select component on dataverse form, added bundle…

dfa4b4d

… info msg [ref #5615]

Merge branch 'develop' into 5615-add-data-navbar

5b75af9

djbrooke added this to the 4.18 milestone Nov 4, 2019

djbrooke assigned scolapasta Nov 4, 2019

scolapasta removed their assignment Nov 4, 2019

djbrooke assigned landreev Nov 4, 2019

landreev added 4 commits November 5, 2019 18:58

experimental framework for pre-selecting the dataverses where the use…

864efa1

…r is allowed to add datasets... this is not fully acceptable either, unfortunately (#5615)

switched to using the type-to-select method for choosing the host dat…

03e8f5f

…averse (#5615)

same, for the dataverse page as well (#5615)

d452c46

removed some verbose debugging messages. (#5615)

640fca1

landreev assigned scolapasta Nov 6, 2019

landreev requested a review from scolapasta November 6, 2019 22:22

mheppler self-assigned this Nov 6, 2019

landreev and others added 5 commits November 7, 2019 10:59

a small pattern matching refinement (#5615)

12c8971

Cleaned up markup and CSS for autoComplete component on edit datavers…

794b525

…e, dataset forms plus other instances [ref #5615]

put the static host dataverse display back on the dataverse page, in …

059125e

…the "edit existing dataverse" mode. (#5615)

added "no matches" message to the autocomplete on the dataverse page. (…

9e962e9

…#5615)

added "no matches" message to the autocomplete on the dataset page. (#…

36bf30d

…5615)

scolapasta reviewed Nov 7, 2019

View reviewed changes

Comment thread doc/sphinx-guides/source/user/dataverse-management.rst Outdated

mheppler and others added 2 commits November 7, 2019 13:38

Moved list item for Host Dataverse...

09f5a71

to top of list since it is at the top of the form now [ref #5615]

simplified the selection logic when performed by a superuser (#5615)

561d299

scolapasta approved these changes Nov 7, 2019

View reviewed changes

scolapasta removed their assignment Nov 7, 2019

mheppler unassigned mheppler and landreev Nov 7, 2019

reorganized the search query code/added some final optimization fine-…

e6c989e

…tuning (#5615)

mheppler and others added 3 commits November 8, 2019 15:37

Changed id on hidden input to avoid duplicate id errors on create dv …

6360f4e

…[ref #5615]

fixes the "duplicate id" issue with the autocomplete component, and w…

84e0857

…rong owner dataverse on create. (#5615)

removed the binding attribute from the host dataverse autoComplete. (#…

81020ab

…5615)

landreev assigned kcondon Nov 12, 2019

kcondon merged commit 9f013a7 into develop Nov 12, 2019

kcondon deleted the 5615-add-data-navbar branch November 12, 2019 19:34

landreev restored the 5615-add-data-navbar branch November 19, 2019 15:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

5615 "add data" button on navbar - #6338

5615 "add data" button on navbar#6338
kcondon merged 40 commits into
developIQSS/dataverse:developfrom
5615-add-data-navbarIQSS/dataverse:5615-add-data-navbarCopy head branch name to clipboard

landreev commented Nov 1, 2019 •

edited

Loading

Uh oh!

coveralls commented Nov 1, 2019 •

edited

Loading

Uh oh!

Uh oh!

kcondon commented Nov 8, 2019

Uh oh!

landreev commented Nov 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Search code, repositories, users, issues, pull requests...

Uh oh!

Conversation

landreev commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Contributors

Related Issues

Pull Request Checklist

Uh oh!

coveralls commented Nov 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

kcondon commented Nov 8, 2019

Uh oh!

landreev commented Nov 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

landreev commented Nov 1, 2019 •

edited

Loading

coveralls commented Nov 1, 2019 •

edited

Loading