IQSS/6212 - Support collecting MDC metrics without display - #6255
#6255Merged
kcondon merged 6 commits intoOct 7, 2019
IQSS:developIQSS/dataverse:developfrom
QualitativeDataRepository:IQSS/6212QualitativeDataRepository/dataverse:IQSS/6212Copy head branch name to clipboard
Merged
IQSS/6212 - Support collecting MDC metrics without display#6255kcondon merged 6 commits intoIQSS:developIQSS/dataverse:developfrom QualitativeDataRepository:IQSS/6212QualitativeDataRepository/dataverse:IQSS/6212Copy head branch name to clipboard
kcondon merged 6 commits into
IQSS:developIQSS/dataverse:developfrom
QualitativeDataRepository:IQSS/6212QualitativeDataRepository/dataverse:IQSS/6212Copy head branch name to clipboard
Conversation
added 2 commits
October 3, 2019 21:04
Conflicts: src/main/java/edu/harvard/iq/dataverse/settings/SettingsServiceBean.java
|
Can one of the admins verify this patch? |
pdurbin
requested changes
Oct 4, 2019
pdurbin
left a comment
Member
There was a problem hiding this comment.
Overall this looks fine but we should use settingsWrapper instead of systemConfig for performance, to reduce database lookups.
Contributor
|
@qqmyers I moved this back to Community Dev and it looks like you're already working on the feedback. Let us know when it's ready for us to take another look and we'll get it moved along. Thank you! |
Member
Author
|
@djbrooke - should be ready |
sekmiller
reviewed
Oct 7, 2019
sekmiller
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just a couple of minor things: there's only one change to SystemConfig which is just the adding of a blank line, also once again please update with the latest from our develop branch.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Note that we use the "closes" syntax below to trigger Github's automation to close the corresponding issue once the pull request is merged.
Thanks for your contribution to Dataverse!
Related Issues
Pull Request Checklist