6109 dataset summary cleanup - #6253
#6253Merged
kcondon merged 5 commits intoOct 7, 2019
developIQSS/dataverse:developfrom
6109-dataset-summary-cleanupIQSS/dataverse:6109-dataset-summary-cleanupCopy head branch name to clipboard
Merged
6109 dataset summary cleanup#6253kcondon merged 5 commits intodevelopIQSS/dataverse:developfrom 6109-dataset-summary-cleanupIQSS/dataverse:6109-dataset-summary-cleanupCopy head branch name to clipboard
kcondon merged 5 commits into
developIQSS/dataverse:developfrom
6109-dataset-summary-cleanupIQSS/dataverse:6109-dataset-summary-cleanupCopy head branch name to clipboard
Conversation
|
Can one of the admins verify this patch? |
sekmiller
reviewed
Oct 4, 2019
Contributor
Author
|
@sekmiller Good question. Thank you for looking at the PR with that level of detail. The There are other accessibility issues to address on the dataset pg edit/create form, and we can address those in another issue. |
Contributor
|
@mheppler It's such a big change that I wanted to make sure I understood what was going on. It looks good so I'm going to pass it along. |
sekmiller
approved these changes
Oct 4, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
labeltag outside of form (viewMode) #6109 Metadata Labels - Review use oflabeltag outside of form (viewMode)Pull Request Checklist