[common] Support 32-bit builds#448
Open
Hans-Halverson wants to merge 2 commits into
Open
[common] Support 32-bit builds#448Hans-Halverson wants to merge 2 commits into
Hans-Halverson wants to merge 2 commits into
Conversation
Hans-Halverson
force-pushed
the
32-bit-support
branch
7 times, most recently
from
July 14, 2026 01:14
f862861 to
a618229
Compare
Hans-Halverson
force-pushed
the
32-bit-support
branch
from
July 14, 2026 01:19
a618229 to
bfcb4fd
Compare
Hans-Halverson
force-pushed
the
32-bit-support
branch
from
July 14, 2026 18:54
bfcb4fd to
ec1c6bf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for 32-bit builds. Mostly fixing a few places we were incorrectly using
usizeinstead the fixed 64-bitValuesize.HeapVIsitor::visit_valueneeds to explicitly convert between pointers/values instead of transmuting refto_indexand typed array constructors.Tests
i686-unknown-linux-gnu)