feat: teleport sounds#1099
Open
DesecratedTree wants to merge 1 commit into
GregHib:mainGregHib/void:mainfrom
DesecratedTree:feat-teleport-soundsDesecratedTree/void:feat-teleport-soundsCopy head branch name to clipboard
Open
feat: teleport sounds#1099DesecratedTree wants to merge 1 commit intoGregHib:mainGregHib/void:mainfrom DesecratedTree:feat-teleport-soundsDesecratedTree/void:feat-teleport-soundsCopy head branch name to clipboard
DesecratedTree wants to merge 1 commit into
GregHib:mainGregHib/void:mainfrom
DesecratedTree:feat-teleport-soundsDesecratedTree/void:feat-teleport-soundsCopy head branch name to clipboard
Conversation
Contributor
|
Lovely! to see this. I am just popin in here and there. No time unfortunately. |
GregHib
reviewed
Jul 19, 2026
| player.exp(Skill.Magic, xp) | ||
| if (sound) { | ||
| player.sound("teleport_${type}") | ||
| if (type == "tablet") { |
Owner
There was a problem hiding this comment.
If you add the ids as teleport_tablet and teleport_jewellery to .sounds.toml that should work
Contributor
There was a problem hiding this comment.
I am seeing the file currently, and the those ids and name that you suggested Greg already exists. Then how come it does not play the sound?
Although teleport land is et to id 201, maybe I'll test that out with changing it to 200. Nope. Going to further and debug and see what whats happening.
Contributor
There was a problem hiding this comment.
Ah I found the fix. Its 👍🏻
[teleport_modern]
id = 200
skalfate
suggested changes
Jul 23, 2026
Author
|
I will go ahead and update the PR when I get home tonight. Thank you!
…On Thu, Jul 23, 2026 at 1:23 PM Skal Fate ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Hiya Hawthorne, This is the change that is needed in the following file
data/skill/magic/teleport/teleport.sounds.toml
[teleport_modern]
id = 200
—
Reply to this email directly, view it on GitHub
<#1099?email_source=notifications&email_token=AMQ5RICVPSQBXN7LRCMS56T5GJJZTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZWGY4TQMBYG42KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4766980874>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQ5RIEUAPULALG4NMEPEB35GJJZTAVCNFSNUABFKJSXA33TNF2G64TZHMZTEMJRHEYDONZSHNEXG43VMU5TIOJSGAYDSNJWHE4KC5QC>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AMQ5RIESKKNP4PUH7KOL2YT5GJJZTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZWGY4TQMBYG42KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/AMQ5RIA7NDJB4HXFSYG4JT35GJJZTA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINZWGY4TQMBYG42KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
still need to add jewelry sounds but this should work for now