feat(chart/webapp): add s3.external.useIam to support IRSA / Workload Identity#17
Open
ConProgramming wants to merge 1 commit into
mainGovSignals/trigger.dev:mainfrom
upstream-pr/s3-external-useiamGovSignals/trigger.dev:upstream-pr/s3-external-useiamCopy head branch name to clipboard
Open
feat(chart/webapp): add s3.external.useIam to support IRSA / Workload Identity#17ConProgramming wants to merge 1 commit intomainGovSignals/trigger.dev:mainfrom upstream-pr/s3-external-useiamGovSignals/trigger.dev:upstream-pr/s3-external-useiamCopy head branch name to clipboard
ConProgramming wants to merge 1 commit into
mainGovSignals/trigger.dev:mainfrom
upstream-pr/s3-external-useiamGovSignals/trigger.dev:upstream-pr/s3-external-useiamCopy head branch name to clipboard
Conversation
… Identity When s3.external.useIam: true, the webapp skips the OBJECT_STORE_ACCESS_KEY_ID and OBJECT_STORE_SECRET_ACCESS_KEY env vars entirely. The AWS SDK then falls back to its credential-provider chain (web-identity-token file, instance metadata, etc.), which is how IRSA on EKS / Workload Identity on GKE authenticate workloads without static access keys. Default is false, matching today's behavior. Pair with a ServiceAccount annotation (e.g. `eks.amazonaws.com/role-arn`) on webapp.serviceAccount. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
s3.external.useIamto the Helm chart. When true, the webapp skips mountingOBJECT_STORE_ACCESS_KEY_ID/OBJECT_STORE_SECRET_ACCESS_KEYenv vars so the AWS SDK can use IRSA (EKS) / Workload Identity (GKE) / instance metadata for credentials.Pure additive change —
useIam: falsedefault preserves current behavior.Notes
eks.amazonaws.com/role-arnannotation onwebapp.serviceAccountfor IRSA.Made with Cursor