Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix echo_api_key#678

Merged
theacodes merged 1 commit into
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
erlichmen:patch-1erlichmen/python-docs-samples:patch-1Copy head branch name to clipboard
Nov 29, 2016
Merged

fix echo_api_key#678
theacodes merged 1 commit into
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
erlichmen:patch-1erlichmen/python-docs-samples:patch-1Copy head branch name to clipboard

Conversation

@erlichmen

Copy link
Copy Markdown
Contributor

echo_api_key was not implemented correctly (looks like a cut and paste bug).
I discover this when trying to follow the instructions on how to implement cloud endpoints on AppEngine standard. and the following command failed:
python lib/endpoints/endpointscfg.py get_swagger_spec main.EchoApi --hostname your-service.appspot.com

with:
endpoints.api_exceptions.ApiConfigurationError: POST path "echo" used multiple times, in classes EchoApi and EchoApi

echo_api_key was not implemented correctly (looks like a cut and paste bug).
I discover this when trying to follow the instructions[1]  on how to implement cloud endpoints on AppEngine standard.
and the following command failed:
   python lib/endpoints/endpointscfg.py get_swagger_spec main.EchoApi --hostname your-service.appspot.com

with:
   endpoints.api_exceptions.ApiConfigurationError: POST path "echo" used multiple times, in classes EchoApi and EchoApi

 [1] https://cloud.google.com/endpoints/docs/frameworks/python/quickstart-frameworks-python
@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 22, 2016
@erlichmen

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 22, 2016
@theacodes

Copy link
Copy Markdown
Contributor

@bradfriedman or @saicheems can one of you take a look at this?

@theacodes

Copy link
Copy Markdown
Contributor

Well, this looks close enough to me. @bradfriedman or @saicheems if you have any follow-ups I'll fix them in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.