Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add gRPC api config files.#675

Merged
theacodes merged 2 commits into
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
qiwzhang:masterqiwzhang/python-docs-samples:masterCopy head branch name to clipboard
Nov 21, 2016
Merged

Add gRPC api config files.#675
theacodes merged 2 commits into
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
qiwzhang:masterqiwzhang/python-docs-samples:masterCopy head branch name to clipboard

Conversation

@qiwzhang

Copy link
Copy Markdown
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2016
@qiwzhang

Copy link
Copy Markdown
Contributor Author

@wlu2016, @kyessenov, @lizan for review

@qiwzhang

Copy link
Copy Markdown
Contributor Author

@jeffmendoza Can you review?

@kyessenov

Copy link
Copy Markdown
Contributor

Can we rename YAML files to bookstore_config.yaml and so on?
I think we need to be careful not to make it easy to confuse these files with Kubernetes manifests.

@qiwzhang

Copy link
Copy Markdown
Contributor Author

OK, I will rename them to bookstore_api_config.yaml and bookstore_http_api_config.yaml

@jeffmendoza jeffmendoza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theacodes theacodes merged commit 1f9432d into GoogleCloudPlatform:master Nov 21, 2016
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.