Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Revert & fix "Revert "Lint session should check all changed files. (#…#621

Merged
theacodes merged 2 commits into
masterGoogleCloudPlatform/python-docs-samples:masterfrom
lintGoogleCloudPlatform/python-docs-samples:lintCopy head branch name to clipboard
Oct 27, 2016
Merged

Revert & fix "Revert "Lint session should check all changed files. (#…#621
theacodes merged 2 commits into
masterGoogleCloudPlatform/python-docs-samples:masterfrom
lintGoogleCloudPlatform/python-docs-samples:lintCopy head branch name to clipboard

Conversation

@jerjou

@jerjou jerjou commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

…619)""

This reverts commit ae8dccb.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 27, 2016
@jerjou

jerjou commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

(tested manually by running nox -s lint . in a virtualenv)

@jerjou jerjou added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou

jerjou commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

(actually - hold off - I realize my test was a little suspicious.. investigating..)

@theacodes

theacodes commented Oct 27, 2016

Copy link
Copy Markdown
Contributor

I don't think you should run nox -s lint ., nox is supposed to run a separate lint for each sample because of local import names.

@jerjou jerjou removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 27, 2016
@jerjou

jerjou commented Oct 27, 2016

Copy link
Copy Markdown
Contributor Author

Okay - fixed. Also fixed a bunch of lint errors. PTAL.

@theacodes theacodes merged commit aac0e02 into master Oct 27, 2016
@theacodes theacodes deleted the lint branch October 27, 2016 19:15
Linchin pushed a commit that referenced this pull request Aug 18, 2025
@renovate-bot @parthea
chore(deps): update dependency google-cloud-bigquery to v3.11.4 (#621)
37bad29 
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
@Linchin Linchin mentioned this pull request Aug 18, 2025
Merged
9 tasks
chalmerlowe pushed a commit that referenced this pull request Feb 19, 2026
@gcf-owl-bot
chore: Bump gapic-generator-python version to 1.3.0 (#621)
27de41f 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 472561635

Source-Link: googleapis/googleapis@332ecf5

Source-Link: https://github.com/googleapis/googleapis-gen/commit/4313d682880fd9d7247291164d4e9d3d5bd9f177
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDMxM2Q2ODI4ODBmZDlkNzI0NzI5MTE2NGQ0ZTlkM2Q1YmQ5ZjE3NyJ9
@chalmerlowe chalmerlowe mentioned this pull request Feb 19, 2026
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jerjou @theacodes @googlebot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.