Add DICOMweb retrieve instance/image and download them to machine#2331
Merged
gguuss merged 2 commits intoAug 13, 2019
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
noerog:chc-python-dicomwebCopy head branch name to clipboard
Merged
Add DICOMweb retrieve instance/image and download them to machine#2331gguuss merged 2 commits intoGoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom noerog:chc-python-dicomwebCopy head branch name to clipboard
gguuss merged 2 commits into
GoogleCloudPlatform:masterGoogleCloudPlatform/python-docs-samples:masterfrom
noerog:chc-python-dicomwebCopy head branch name to clipboard
Conversation
gguuss
approved these changes
Aug 12, 2019
gguuss
left a comment
Contributor
There was a problem hiding this comment.
LGTM after removing the string concatenation. Let me know if/when you want merged.
| # server and are part of the metadata of dcm_file | ||
| study_uid = '1.3.6.1.4.1.11129.5.5.111396399361969898205364400549799252857604' | ||
| series_uid = '1.3.6.1.4.1.11129.5.5.195628213694300498946760767481291263511724' | ||
| instance_uid = '1.3.6.1.4.1.11129.5.5.' + \ |
Contributor
There was a problem hiding this comment.
Use format instead of string continuation:
instance_uid = '{}.{}'.format(
'1.3.6.1.4.1.11129.5.5',
'153751009835107614666834563294684339746480')
Contributor
Author
There was a problem hiding this comment.
Done. Please merge when you can.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.