Update main.py#2309
Merged
gguuss merged 1 commit intoAug 16, 2019
Merged
Update main.py#2309gguuss merged 1 commit into
gguuss merged 1 commit into
Conversation
Wrong format of 'unix_socket inside the query parameter in sqlalchemy.create_engine.
Doing:
'/cloudsql/{}/'.format(cloud_sql_connection_name)
takes the path as a direcytory, the ending slash needs to be removed:
'/cloudsql/{}'.format(cloud_sql_connection_name)
gguuss
approved these changes
Aug 15, 2019
gguuss
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrong format of 'unix_socket inside the query parameter in sqlalchemy.create_engine.
Doing:
'/cloudsql/{}/'.format(cloud_sql_connection_name)
takes the path as a direcytory, the ending slash needs to be removed:
'/cloudsql/{}'.format(cloud_sql_connection_name)