-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat : Create compute shared reservation Sample #12678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ccc97b4
Ingredient and recipe
Thoughtseize1 967cd58
Create compute shared reservation file with updated test
Thoughtseize1 dae8117
Lint fix
Thoughtseize1 c36229d
Refactored tests for all reservations
Thoughtseize1 2890f77
Refactored test: Added error handling for reservation deletion and up…
Thoughtseize1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
95 changes: 95 additions & 0 deletions
95
compute/client_library/ingredients/compute_reservation/create_compute_shared_reservation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# This is an ingredient file. It is not meant to be run directly. Check the samples/snippets | ||
# folder for complete code samples that are ready to be used. | ||
# Disabling flake8 for the ingredients file, as it would fail F821 - undefined name check. | ||
# flake8: noqa | ||
|
||
from google.cloud import compute_v1 | ||
|
||
|
||
# <INGREDIENT create_compute_shared_reservation> | ||
def create_compute_shared_reservation( | ||
project_id: str, | ||
zone: str = "us-central1-a", | ||
reservation_name="your-reservation-name", | ||
shared_project_id: str = "shared-project-id", | ||
) -> compute_v1.Reservation: | ||
"""Creates a compute reservation in GCP. | ||
Args: | ||
project_id (str): The ID of the Google Cloud project. | ||
zone (str): The zone to create the reservation. | ||
reservation_name (str): The name of the reservation to create. | ||
shared_project_id (str): The ID of the project that the reservation is shared with. | ||
Returns: | ||
Reservation object that represents the new reservation. | ||
""" | ||
|
||
instance_properties = compute_v1.AllocationSpecificSKUAllocationReservedInstanceProperties( | ||
machine_type="n1-standard-1", | ||
# Optional. Specifies amount of local ssd to reserve with each instance. | ||
local_ssds=[ | ||
compute_v1.AllocationSpecificSKUAllocationAllocatedInstancePropertiesReservedDisk( | ||
disk_size_gb=375, interface="NVME" | ||
), | ||
], | ||
) | ||
|
||
reservation = compute_v1.Reservation( | ||
name=reservation_name, | ||
specific_reservation=compute_v1.AllocationSpecificSKUReservation( | ||
count=3, # Number of resources that are allocated. | ||
# If you use source_instance_template, you must exclude the instance_properties field. | ||
# It can be a full or partial URL. | ||
# source_instance_template="projects/[PROJECT_ID]/global/instanceTemplates/my-instance-template", | ||
instance_properties=instance_properties, | ||
), | ||
share_settings=compute_v1.ShareSettings( | ||
share_type="SPECIFIC_PROJECTS", | ||
project_map={ | ||
shared_project_id: compute_v1.ShareSettingsProjectConfig( | ||
project_id=shared_project_id | ||
) | ||
}, | ||
), | ||
) | ||
|
||
# Create a client | ||
client = compute_v1.ReservationsClient() | ||
|
||
operation = client.insert( | ||
project=project_id, | ||
zone=zone, | ||
reservation_resource=reservation, | ||
) | ||
wait_for_extended_operation(operation, "Reservation creation") | ||
|
||
reservation = client.get( | ||
project=project_id, zone=zone, reservation=reservation_name | ||
) | ||
shared_project = next(iter(reservation.share_settings.project_map.values())) | ||
|
||
print("Name: ", reservation.name) | ||
print("STATUS: ", reservation.status) | ||
print("SHARED PROJECT: ", shared_project) | ||
# Example response: | ||
# Name: your-reservation-name | ||
# STATUS: READY | ||
# SHARED PROJECT: project_id: "123456789012" | ||
|
||
return reservation | ||
|
||
|
||
# </INGREDIENT> |
21 changes: 21 additions & 0 deletions
21
compute/client_library/recipes/compute_reservations/create_compute_shared_reservation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
# <REGION compute_reservation_create_shared> | ||
# <IMPORTS/> | ||
|
||
# <INGREDIENT wait_for_extended_operation /> | ||
|
||
# <INGREDIENT create_compute_shared_reservation /> | ||
# </REGION compute_reservation_create_shared> |
150 changes: 150 additions & 0 deletions
150
compute/client_library/snippets/compute_reservations/create_compute_shared_reservation.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
# Copyright 2024 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# https://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
|
||
# This file is automatically generated. Please do not modify it directly. | ||
# Find the relevant recipe file in the samples/recipes or samples/ingredients | ||
# directory and apply your changes there. | ||
|
||
|
||
# [START compute_reservation_create_shared] | ||
from __future__ import annotations | ||
|
||
import sys | ||
from typing import Any | ||
|
||
from google.api_core.extended_operation import ExtendedOperation | ||
from google.cloud import compute_v1 | ||
|
||
|
||
def wait_for_extended_operation( | ||
operation: ExtendedOperation, verbose_name: str = "operation", timeout: int = 300 | ||
) -> Any: | ||
""" | ||
Waits for the extended (long-running) operation to complete. | ||
|
||
If the operation is successful, it will return its result. | ||
If the operation ends with an error, an exception will be raised. | ||
If there were any warnings during the execution of the operation | ||
they will be printed to sys.stderr. | ||
|
||
Args: | ||
operation: a long-running operation you want to wait on. | ||
verbose_name: (optional) a more verbose name of the operation, | ||
used only during error and warning reporting. | ||
timeout: how long (in seconds) to wait for operation to finish. | ||
If None, wait indefinitely. | ||
|
||
Returns: | ||
Whatever the operation.result() returns. | ||
|
||
Raises: | ||
This method will raise the exception received from `operation.exception()` | ||
or RuntimeError if there is no exception set, but there is an `error_code` | ||
set for the `operation`. | ||
|
||
In case of an operation taking longer than `timeout` seconds to complete, | ||
a `concurrent.futures.TimeoutError` will be raised. | ||
""" | ||
result = operation.result(timeout=timeout) | ||
|
||
if operation.error_code: | ||
print( | ||
f"Error during {verbose_name}: [Code: {operation.error_code}]: {operation.error_message}", | ||
file=sys.stderr, | ||
flush=True, | ||
) | ||
print(f"Operation ID: {operation.name}", file=sys.stderr, flush=True) | ||
raise operation.exception() or RuntimeError(operation.error_message) | ||
|
||
if operation.warnings: | ||
print(f"Warnings during {verbose_name}:\n", file=sys.stderr, flush=True) | ||
for warning in operation.warnings: | ||
print(f" - {warning.code}: {warning.message}", file=sys.stderr, flush=True) | ||
|
||
return result | ||
|
||
|
||
def create_compute_shared_reservation( | ||
project_id: str, | ||
zone: str = "us-central1-a", | ||
reservation_name="your-reservation-name", | ||
shared_project_id: str = "shared-project-id", | ||
) -> compute_v1.Reservation: | ||
"""Creates a compute reservation in GCP. | ||
Args: | ||
project_id (str): The ID of the Google Cloud project. | ||
zone (str): The zone to create the reservation. | ||
reservation_name (str): The name of the reservation to create. | ||
shared_project_id (str): The ID of the project that the reservation is shared with. | ||
Returns: | ||
Reservation object that represents the new reservation. | ||
""" | ||
|
||
instance_properties = compute_v1.AllocationSpecificSKUAllocationReservedInstanceProperties( | ||
machine_type="n1-standard-1", | ||
# Optional. Specifies amount of local ssd to reserve with each instance. | ||
local_ssds=[ | ||
compute_v1.AllocationSpecificSKUAllocationAllocatedInstancePropertiesReservedDisk( | ||
disk_size_gb=375, interface="NVME" | ||
), | ||
], | ||
) | ||
|
||
reservation = compute_v1.Reservation( | ||
name=reservation_name, | ||
specific_reservation=compute_v1.AllocationSpecificSKUReservation( | ||
count=3, # Number of resources that are allocated. | ||
# If you use source_instance_template, you must exclude the instance_properties field. | ||
# It can be a full or partial URL. | ||
# source_instance_template="projects/[PROJECT_ID]/global/instanceTemplates/my-instance-template", | ||
instance_properties=instance_properties, | ||
), | ||
share_settings=compute_v1.ShareSettings( | ||
share_type="SPECIFIC_PROJECTS", | ||
project_map={ | ||
shared_project_id: compute_v1.ShareSettingsProjectConfig( | ||
project_id=shared_project_id | ||
) | ||
}, | ||
), | ||
) | ||
|
||
# Create a client | ||
client = compute_v1.ReservationsClient() | ||
|
||
operation = client.insert( | ||
project=project_id, | ||
zone=zone, | ||
reservation_resource=reservation, | ||
) | ||
wait_for_extended_operation(operation, "Reservation creation") | ||
|
||
reservation = client.get( | ||
project=project_id, zone=zone, reservation=reservation_name | ||
) | ||
shared_project = next(iter(reservation.share_settings.project_map.values())) | ||
|
||
print("Name: ", reservation.name) | ||
print("STATUS: ", reservation.status) | ||
print("SHARED PROJECT: ", shared_project) | ||
# Example response: | ||
# Name: your-reservation-name | ||
# STATUS: READY | ||
# SHARED PROJECT: project_id: "123456789012" | ||
|
||
return reservation | ||
|
||
|
||
# [END compute_reservation_create_shared] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That class name is ridiculous 🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But I don't know what I could do with that 🤷♂️
Maybe we could make a request to update the library. Then I could use more readable names here! 😄