feat : Create compute shared reservation Sample #12678
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
m-strzelczyk
requested changes
Oct 11, 2024
| machine_type="n1-standard-1", | ||
| # Optional. Specifies amount of local ssd to reserve with each instance. | ||
| local_ssds=[ | ||
| compute_v1.AllocationSpecificSKUAllocationAllocatedInstancePropertiesReservedDisk( |
There was a problem hiding this comment.
That class name is ridiculous 🤣
There was a problem hiding this comment.
But I don't know what I could do with that 🤷♂️
Maybe we could make a request to update the library. Then I could use more readable names here! 😄
compute/client_library/snippets/tests/test_compute_reservation.py
Outdated
Show resolved
Hide resolved
m-strzelczyk
approved these changes
Oct 21, 2024
jacspa96
pushed a commit
to jacspa96/python-docs-samples
that referenced
this pull request
Oct 30, 2024
…12678) * Create compute shared reservation file with updated test * Refactored tests for all reservations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created Sample for Compute Create Shared Reservation.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)