Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(storage): fix document of delete blob#10015

Merged
crwilcox merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:storage_fix_doc_blob_deleteMaxxleLLC/google-cloud-python:storage_fix_doc_blob_deleteCopy head branch name to clipboard
Jan 10, 2020
Merged

fix(storage): fix document of delete blob#10015
crwilcox merged 2 commits into
googleapis:mastergoogleapis/google-cloud-python:masterfrom
MaxxleLLC:storage_fix_doc_blob_deleteMaxxleLLC/google-cloud-python:storage_fix_doc_blob_deleteCopy head branch name to clipboard

Conversation

@HemangChothani

Copy link
Copy Markdown
Contributor

Fixes #9985

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 24, 2019

@frankyn frankyn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as there shouldn't be a return value on deletes.

Additionally, the API does not return the object resource on a delete operation as well.
https://cloud.google.com/storage/docs/json_api/v1/objects/delete

@crwilcox
crwilcox merged commit 3bb565b into googleapis:master Jan 10, 2020
This was referenced Jan 29, 2020
@HemangChothani
HemangChothani deleted the storage_fix_doc_blob_delete branch January 31, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storage: Blob.delete returns self.bucket.delete_blob but delete_blob returns nothing

5 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.