Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Upgrade google-auth-library-bom to 0.25.0#1987

Merged
suztomo merged 1 commit into
masterGoogleCloudPlatform/cloud-opensource-java:masterfrom
auth_upgradeGoogleCloudPlatform/cloud-opensource-java:auth_upgradeCopy head branch name to clipboard
Mar 17, 2021
Merged

Upgrade google-auth-library-bom to 0.25.0#1987
suztomo merged 1 commit into
masterGoogleCloudPlatform/cloud-opensource-java:masterfrom
auth_upgradeGoogleCloudPlatform/cloud-opensource-java:auth_upgradeCopy head branch name to clipboard

Conversation

@suztomo

@suztomo suztomo commented Mar 17, 2021

Copy link
Copy Markdown
Contributor

For googleapis/gax-java#1302, which fails Linkage Monitor.

CC: @arithmetic1728

@google-cla google-cla Bot added the cla: yes label Mar 17, 2021
@suztomo suztomo requested a review from elharo March 17, 2021 20:53
@suztomo suztomo merged commit 7efed10 into master Mar 17, 2021
@suztomo suztomo deleted the auth_upgrade branch March 17, 2021 21:57
@suztomo

suztomo commented Mar 17, 2021

Copy link
Copy Markdown
Contributor Author

The BOM in the master branch does not affect Linkage Monitor check (It's different from the upper bound check).

The check still fails

SEVERE: Newly introduced problem:
(com.google.auth:google-auth-library-oauth2-http:0.24.1) com.google.auth.oauth2.GoogleCredentials's method createScoped(java.util.Collection, java.util.Collection) is not found
  referenced from com.google.api.gax.core.GoogleCredentialsProvider (com.google.api:gax:1.62.1-SNAPSHOT)

I think I'll need another release for this change to make the change pass.

@suztomo suztomo mentioned this pull request Mar 18, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@elharo elharo elharo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @elharo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.