Limit search pattern and directory recursion - #4647
#4647Merged
arturcic merged 1 commit intoAug 9, 2025
GitTools:mainGitTools/GitVersion:mainfrom
asbjornu:gh-4411-enumerate-filesasbjornu/GitVersion:gh-4411-enumerate-filesCopy head branch name to clipboard
Merged
Limit search pattern and directory recursion#4647arturcic merged 1 commit intoGitTools:mainGitTools/GitVersion:mainfrom asbjornu:gh-4411-enumerate-filesasbjornu/GitVersion:gh-4411-enumerate-filesCopy head branch name to clipboard
arturcic merged 1 commit into
GitTools:mainGitTools/GitVersion:mainfrom
asbjornu:gh-4411-enumerate-filesasbjornu/GitVersion:gh-4411-enumerate-filesCopy head branch name to clipboard
Conversation
asbjornu
force-pushed
the
gh-4411-enumerate-files
branch
2 times, most recently
from
August 8, 2025 23:13
da62f4a to
86ca875
Compare
asbjornu
force-pushed
the
gh-4411-enumerate-files
branch
from
August 8, 2025 23:16
86ca875 to
3693ec5
Compare
2 tasks
asbjornu
force-pushed
the
gh-4411-enumerate-files
branch
from
August 8, 2025 23:23
3693ec5 to
f37a27d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the project file discovery mechanism by limiting the scope and depth of directory traversal to prevent infinite loops and PathTooLongException errors. The changes specifically target scenarios where directory recursion could become problematic.
- Introduces a maximum recursion depth limit of 255 subdirectories
- Narrows the search pattern from "*" to "*proj" to focus on actual project files
- Replaces the legacy
SearchOption.AllDirectorieswith modernEnumerationOptions
Narrow the scope of the search pattern to only include project files and limit directory recursion to 255 subdirectories to avoid infinite loops and subsequent `PathTooLongException`. May fix GitToolsGH-4411.
arturcic
force-pushed
the
gh-4411-enumerate-files
branch
from
August 9, 2025 19:09
f37a27d to
b857ada
Compare
|
arturcic
enabled auto-merge
August 9, 2025 19:14
arturcic
approved these changes
Aug 9, 2025
Contributor
|
Thank you @asbjornu for your contribution! |
Contributor
|
🎉 This issue has been resolved in version 6.4.0 🎉 Your GitReleaseManager bot 📦🚀 |
This was referenced Mar 18, 2026
Closed
Closed
This was referenced Mar 30, 2026
This was referenced Apr 25, 2026
Closed
This was referenced Jun 29, 2026
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Narrow the scope of the search pattern to only include project files and limit directory recursion to 255 subdirectories to avoid infinite loops and subsequent
PathTooLongException.Related Issue
May fix GH-4411.
Checklist: