Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Custom ServiceUrl for S3 compatible services - #121

#121
Open
leonverschuren wants to merge 1 commit into
FubarDevelopment:masterFubarDevelopment/FtpServer:masterfrom
leonverschuren:s3-endpointleonverschuren/FtpServer:s3-endpointCopy head branch name to clipboard
Open

Custom ServiceUrl for S3 compatible services#121
leonverschuren wants to merge 1 commit into
FubarDevelopment:masterFubarDevelopment/FtpServer:masterfrom
leonverschuren:s3-endpointleonverschuren/FtpServer:s3-endpointCopy head branch name to clipboard

Conversation

@leonverschuren

@leonverschuren leonverschuren commented Jan 4, 2022

Copy link
Copy Markdown

Added the option to override the service url, this makes it possible to use the S3 filesystem with S3 compatible storage providers like DigitalOcean Spaces.

This is the recommended solution by DigitalOcean: https://www.digitalocean.com/community/questions/how-to-use-digitalocean-spaces-with-the-aws-s3-sdks?answer=44888

LuisNogal
LuisNogal approved these changes Mar 29, 2023
View reviewed changes

@LuisNogal LuisNogal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this with Vultr object storage and it works fine.

@justinstenning

justinstenning commented Jan 20, 2025

Copy link
Copy Markdown

For containerised solutions like Zenko you may also need to add support for the ForcePathStyle option, e.g.:

src/FubarDev.FtpServer.FileSystem.S3/S3FileSystemOptions.cs:

        /// <summary>
        /// Use path style URLs for S3 (i.e. when using customer endpoints like Zenko)
        /// e.g. https://s3.example.com/bucket/key instead of https://bucket.s3.example.com/key
        /// </summary>
        public bool? ForcePathStyle { get; set; }

src/FubarDev.FtpServer.FileSystem.S3/S3FileSystem.cs:

    config.ServiceURL = options.ServiceUrl;
    config.ForcePathStyle = options.ForcePathStyle == true,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@LuisNogal LuisNogal LuisNogal approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leonverschuren @justinstenning @LuisNogal
Morty Proxy This is a proxified and sanitized view of the page, visit original site.