Allow Symfony v5#37
Allow Symfony v5#3794noni wants to merge 2 commits intoFrDeamon:masterFrDeamon/EnseparHtml2pdfBundle:masterfrom 94noni:feature-sf5Copy head branch name to clipboard
Conversation
|
Friendly ping @OwlyCode |
|
Hello and sorry for the long delay. I've currently very little time to maintain this library. I would even consider giving it away if someone is interested because it deserves better. This PR is great, could you have a look at why the tests are failing? Thanks! |
|
@OwlyCode thanks for the reply, of course i will have a look at the tests The bundle is "quite simple" in its job, there is not so much things it deserves more imho that what is already here :) I may ping you back when this PR is finished/ready 👍 |
|
@OwlyCode maybe PHP v5.4/v5.5 are no more relevant here? or with an other branch/tag? |
|
Hello @Deamon I don't know how I managed that but your message went unnoticed. Are you still ok to take on the lib? |
|
Hi @OwlyCode, I still agree to take the lib. Is it fine for you ? |
|
Hello, any news on this PR? Or any alternative? Failing tests are unrelated. It happens because old PHP version image are no more available to download. |
|
@Deamon I initiated the transfer, you should be able to take over now. Have you got a packagist account so I can add you on it too? |
Nevermind, I found you on packagist. Let me know if you are able to migrate the repository from there too. |
|
@Deamon will you then merge this PR and tag a new release? |
|
@OwlyCode I finally received the transfert email, but after the link was expired. Could'd you reiterate the opération ? |
|
Closing as I now use an internal/private fork @Deamon please feel free to report back when you take over this projet/PR for symfony v5 :) Thank you |
|
Well, I thought I would be able to manage this but I havn't seen those few months. @94noni do you want to take part as a collaborator to this repo ? |
|
@Deamon no i prefer to continue on my repo |
|
I can transfer the ownership to you, would make sense if you continue to work with the bundle. |
|
Hum for now there is nothing more i want/need to add on it |
|
Ok, feel free to come back and ask for it if needed. |
Hi @OwlyCode
I plan to use this bundle inside a Symfony v5 app, that is why I opened this PR (draft for now)
Also, do you think we can create a https://github.com/symfony/recipes-contrib ?
TODO:
pre release tagso we can test itrecipecreationThank you