Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@mitchknife
Copy link
Contributor

@mitchknife mitchknife commented Jan 7, 2025

This is "technically" a breaking change, but I'm almost certain no one is using this code yet (including myself). Should I bump the major version just in case? cc @ejball?

  • Also fixed some type errors introduced with Support DTO required fields as not optional properties on interface in TS. #69. I'll try to add required field validation on another pass, but since I'm likely the only one working with fastify I'm not too worried about it causing a problem in the mean time.
  • Also bumped fastify version to 5.2.1
  • Also made fastify plugin "experimental" so I can make additional changes to the api if needed without bumping the major version.

@mitchknife mitchknife changed the title Fix fastify plugin type errors. Allow for request scoped services instances in fastify plugin. Jan 8, 2025
@mitchknife mitchknife changed the title Allow for request scoped services instances in fastify plugin. Allow for request scoped service instances in fastify plugin. Jan 8, 2025
@ejball
Copy link
Contributor

ejball commented Jan 8, 2025

Should I bump the major version just in case?

No need, thanks for asking.

These errors were introduced with FacilityApi#69
After I've tested this in the wild a bit, I'll remove this and open it up for additional usage in case the folks over at Logos want to start using fastify for some servery things.
@mitchknife mitchknife merged commit 83f074a into FacilityApi:master Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.