Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Support DTO required fields as not optional properties on interface in TS. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
heymb merged 3 commits into from
Aug 5, 2024
Merged

Support DTO required fields as not optional properties on interface in TS. #69

heymb merged 3 commits into from
Aug 5, 2024

Conversation

@heymb
Copy link
Contributor

@heymb heymb commented Aug 5, 2024 •
edited
Loading

At minimum, we could make the fields not optional in TypeScript.

@heymb heymb changed the title Support required fields Support required fields as not optional in TS. Aug 5, 2024
@heymb heymb requested a review from ejball August 5, 2024 14:35
Update version number and release notes per contributing docs since g…
499aa47 
…enerating required fields as not optional is a breaking change
@heymb heymb mentioned this pull request Aug 5, 2024
Closed
@heymb heymb merged commit 265ace3 into FacilityApi:master Aug 5, 2024
@heymb heymb deleted the supportRequiredFields branch August 5, 2024 20:50
@heymb heymb changed the title Support required fields as not optional in TS. Support DTO required fields as not optional properties on interface in TS. Aug 5, 2024
mitchknife added a commit to mitchknife/FacilityJavaScript that referenced this pull request Jan 7, 2025
@mitchknife
Fix fastify plugin type errors.
5a4748d 
These errors were introduced with FacilityApi#69
@mitchknife mitchknife mentioned this pull request Jan 7, 2025
Merged
mitchknife added a commit to mitchknife/FacilityJavaScript that referenced this pull request Feb 12, 2025
@mitchknife
Fix fastify plugin type errors.
3d5597f 
These errors were introduced with FacilityApi#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ejball ejball ejball approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@heymb @ejball
Morty Proxy This is a proxified and sanitized view of the page, visit original site.