Undo notification close (history) #574#578
Undo notification close (history) #574#578ArijanJ wants to merge 4 commits into
Conversation
|
Maybe something like this? The problem I'm seeing with this is if you delete 3/10 notifications in a group, ctrl+z will restore all three at once instead of one by one. We might need to somehow check every single deletion and mark it as either a group-delete or a single-delete, which is likely a bit more work |
ErikReider
left a comment
There was a problem hiding this comment.
Thanks for picking this up! :D
|
I think this simple implementation should be enough for most use cases. I tried implementing full-group restore but it seems to be more complex and I'm not 100% sure on how the events propagate up from each widget/button :( Also moved it to the |
|
@ErikReider what do you think of this fairly simple method of doing it? |
|
Sorry for the late reply, but I'd be more comfortable getting a SQLite implementation in before this. I have a "working" initial implementation, but haven't pushed anything yet. Thoughts? :) |
|
Yeah of course, whatever you decide. Do you plan on making UI for browsing through it? |
Initially no, but it wouldn't be difficult at all to add. I just need to make sure that everything is up to snuff before I push :) |
Opening this PR early so we can discuss how this would ideally work. It's bound to ctrl+z for now, and so far this method looks promising, although I haven't tested it much.
For groups, I assume we would want it to undo the deletion of the entire group, and I was also curious if it's better to somehow stick the restored notifications to the top of the list. I tried this with the two commented-out lines, but might need to reposition the widget itself if we want to go this route. What do we think?