This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Re-activate and Update Alltop.com.xml#9862
Merged
J0WI merged 1 commit intoMay 19, 2017
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:cschanaj-alltop.comCopy head branch name to clipboard
Merged
Re-activate and Update Alltop.com.xml#9862J0WI merged 1 commit intoEFForg:masterEFForg/https-everywhere:masterfrom cschanaj:cschanaj-alltop.comCopy head branch name to clipboard
J0WI merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
cschanaj:cschanaj-alltop.comCopy head branch name to clipboard
Conversation
J0WI
reviewed
May 14, 2017
| --> | ||
| <ruleset name="AllTop.com"> | ||
| <target host="alltop.com" /> | ||
| <target host="*.alltop.com" /> |
Contributor
There was a problem hiding this comment.
Is there also a reason to use a wildcard target or can we list all hosts?
Collaborator
Author
There was a problem hiding this comment.
The wildcard DNS basically redirect https://foo.alltop.com to http://alltop.com/?keywords=foo. And there is 700+ sub-domain support HTTPS correctly. I do not want this to overwhelm reviewers and future maintainers. If you prefer, I can rebase it.
See https://gist.github.com/cschanaj/f0fdfa8f0535ded83603b1dfe1827b4e (Only checked automatically).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #9842