This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Add eslint config#8843
Closed
CapacitorSet wants to merge 1 commit into
Closed
Add eslint config#8843CapacitorSet wants to merge 1 commit into
CapacitorSet wants to merge 1 commit into
Conversation
Contributor
|
@Hainish maybe this can also be added to Travis? |
Author
|
If it is approved, I can add it to Travis in the same PR. |
Hainish
suggested changes
Mar 28, 2017
| if (canonical_host.charAt(canonical_host.length - 1) == ".") { | ||
| while (canonical_host.charAt(canonical_host.length - 1) == ".") | ||
| canonical_host = canonical_host.slice(0,-1); | ||
| {canonical_host = canonical_host.slice(0,-1);} |
Member
There was a problem hiding this comment.
I find this style odd, I'd prefer the open block { at the end of the previous line with a space after the ) (as in line 213) and the close block } on a new line.
Author
|
Ping @Hainish, I fixed the weird braces. |
Closed
Member
|
When I run the linter I'm getting a larger number of spaces before the opening of blocks. I'm using your |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the eslint config used in EFForg/privacybadger, and fixes some linting issues.