Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Ruleset change tests (resolves #5844)#6052

Merged
cooperq merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
Hainish:ruleset-change-testsHainish/https-everywhere:ruleset-change-testsCopy head branch name to clipboard
Aug 11, 2016
Merged

Ruleset change tests (resolves #5844)#6052
cooperq merged 1 commit into
EFForg:masterEFForg/https-everywhere:masterfrom
Hainish:ruleset-change-testsHainish/https-everywhere:ruleset-change-testsCopy head branch name to clipboard

Conversation

@Hainish

@Hainish Hainish commented Aug 3, 2016

Copy link
Copy Markdown
Member

… checking (resolves #5844)

@Hainish

Hainish commented Aug 3, 2016

Copy link
Copy Markdown
Member Author

Ready for review @cooperq @jsha

Comment thread test/travis-ruleset-fetch.sh Outdated
echo >&2 "Ruleset database has changed. Testing test URLs in all changed rulesets."
echo >&2 "Ruleset database has changed."

echo >&2 "Performing comprehensive coverge test."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a typo.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching it!

@Hainish Hainish force-pushed the ruleset-change-tests branch 3 times, most recently from 031458d to e0ebbd9 Compare August 11, 2016 00:31
@Hainish Hainish force-pushed the ruleset-change-tests branch from e0ebbd9 to f6fa38d Compare August 11, 2016 00:33
@cooperq

cooperq commented Aug 11, 2016

Copy link
Copy Markdown
Contributor

lgtm

@cooperq cooperq merged commit 035c9ae into EFForg:master Aug 11, 2016
@Hainish Hainish deleted the ruleset-change-tests branch February 23, 2018 01:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only do fetch test for ruleset changing PRs

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.