Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Added myescambia.com and firehousesubs.com#5809

Closed
Caboosey wants to merge 4 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
Caboosey:masterCaboosey/https-everywhere:masterCopy head branch name to clipboard
Closed

Added myescambia.com and firehousesubs.com#5809
Caboosey wants to merge 4 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
Caboosey:masterCaboosey/https-everywhere:masterCopy head branch name to clipboard

Conversation

@Caboosey

Copy link
Copy Markdown
Contributor

Added myescambia.com ruleset

Added myescambia.com ruleset
@Hainish Hainish added the top-1m label Aug 19, 2016
@Caboosey

Caboosey commented Sep 22, 2016

Copy link
Copy Markdown
Contributor Author

myescambia.com is a local government website. It ranks in the top 1m globally, but ranks in top 100k in United States.

@Caboosey Caboosey changed the title Added myescambia.com Added myescambia.com and firehousesubs.com Sep 22, 2016
@Caboosey

Copy link
Copy Markdown
Contributor Author

firehousesubs.com is a top 100k site globally.

@jeremyn

jeremyn commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

@Caboosey Are you still interested in working on this?

@Caboosey

Copy link
Copy Markdown
Contributor Author

@jeremyn I am. I submitted changes and awaiting for it to be merged.

@jeremyn

jeremyn commented Nov 28, 2016

Copy link
Copy Markdown
Contributor

Great! First thing, these two rulesets seem unrelated to each other. Please create a new pull request for one of them and delete it from this pull request. Please ping me on the new pull request. I'll work with you on both, I just want to split them up to organize things better.

@jeremyn jeremyn self-assigned this Nov 28, 2016
@jeremyn

jeremyn commented Dec 11, 2016

Copy link
Copy Markdown
Contributor

@Caboosey Will you be able to work on this pull request soon? If not, I would prefer to close it and note the domains you wanted to add in issue #3069, which is where we currently list domains that could use attention.

@jeremyn

jeremyn commented Dec 18, 2016

Copy link
Copy Markdown
Contributor

Please make the following changes to myescambia.com.xml and delete firehousesubs.com.xml:

Add target:

Mark as Invalid certificate in a top comment (example):

Mark as Redirects to HTTP in a top comment:

Also:

  • Delete firehousesubs.com.xml, which should go into another pull request
  • Rename myescambia.com.xml to Escambia_County_FL_US.xml
  • Change the ruleset name to Escambia County, FL, US
  • Indent with one tab instead of spaces, following our style guide

@jeremyn

jeremyn commented Jan 25, 2017

Copy link
Copy Markdown
Contributor

@Caboosey I'm checking in on this pull request. Are you planning on making the changes I asked for?

@Caboosey

Copy link
Copy Markdown
Contributor Author

Someone else can make changes.

@Caboosey Caboosey closed this Jan 26, 2017
@jeremyn jeremyn removed their assignment Jan 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.