This repository was archived by the owner on Nov 6, 2023. It is now read-only.
Create Criosweb.xml#5147
Merged
J0WI merged 13 commits intoJul 11, 2016
EFForg:masterEFForg/https-everywhere:masterfrom
ivysrono:patch-140Copy head branch name to clipboard
Merged
Create Criosweb.xml#5147J0WI merged 13 commits intoEFForg:masterEFForg/https-everywhere:masterfrom ivysrono:patch-140Copy head branch name to clipboard
J0WI merged 13 commits into
EFForg:masterEFForg/https-everywhere:masterfrom
ivysrono:patch-140Copy head branch name to clipboard
Conversation
Closed
|
|
||
| <!-- mixed content issues on https://infoeuri.criosweb.ro/blog/ and https://luci.criosweb.ro/ --> | ||
|
|
||
| <rule from="^http://(infoeuri|luci)\.criosweb\.ro/(blog/)?wp-(content|includes)/(.+)" |
Contributor
There was a problem hiding this comment.
They need to be included as target hosts.
| <target host="criosweb.ro" /> | ||
| <target host="www.criosweb.ro" /> | ||
|
|
||
| <rule from="^http:" to="https:" /> |
Contributor
There was a problem hiding this comment.
This will overwrite the exclusions in L9
|
|
||
| <target host="criosweb.ro" /> | ||
| <target host="www.criosweb.ro" /> | ||
| <rule from="^http://(www\.)?criosweb\.ro/" to="https://www.criosweb.ro/" /> |
Contributor
There was a problem hiding this comment.
Why do you redirect non-www to www?
added 2 commits
June 25, 2016 22:58
| to="https://infoeuri.criosweb.ro/" /> | ||
| <test url="http://infoeuri.criosweb.ro/" /> | ||
| <test url="http://infoeuri.criosweb.ro/blog/wp-content/uploads/2014/07/august-1038x576.jpg" /> | ||
| <test url="http://infoeuri.criosweb.ro/blog/wp-includes/js/tw-sack.min.js" /> |
Contributor
There was a problem hiding this comment.
Now they are covered by the exclusion above too.
added 2 commits
June 26, 2016 11:33
| <target host="criosweb.ro" /> | ||
| <target host="www.criosweb.ro" /> | ||
|
|
||
| <rule from="^http://(www\.)?criosweb\.ro/" to="https://www.criosweb.ro/" /> |
Contributor
There was a problem hiding this comment.
why do you redirect ^ to www?
Contributor
There was a problem hiding this comment.
We use to not touch any server side redirects except they break something.
| <target host="www.criosweb.ro" /> | ||
|
|
||
| <rule from="^http://(www\.)?criosweb\.ro/" to="https://www.criosweb.ro/" /> | ||
| <rule from="^http:" to="https:" /> |
Contributor
There was a problem hiding this comment.
This would also affect the hosts above.
You have to explicit redirect (www\.)?criosweb\.ro to $1criosweb.ro.
added 2 commits
July 11, 2016 21:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.